You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2013/03/06 07:42:59 UTC

Review Request: Fix the integration scripts for nose import and ostypeid corrections

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9769/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Description
-------


  Fix the integration scripts for nose import and ostypeid corrections

    from nose.plugins.attrib import attr

    "ostype": 'CentOS 5.3 (64-bit)',

            template = get_template(
                                cls.api_client,
                                cls.zone.id,
                                cls.services["ostype"]
                                )


This addresses bug CLOUDSTACK-1530.


Diffs
-----

  docs/en-US/add-remove-nic.xml PRE-CREATION 
  docs/en-US/added-API-commands-4-1.xml f635e9d 
  docs/en-US/whats-new.xml 29ae1f6 
  server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java 5d0b01c 
  test/integration/component/test_accounts.py d0b4434 
  test/integration/component/test_allocation_states.py 006f879 
  test/integration/component/test_blocker_bugs.py cc5da0a 
  test/integration/component/test_egress_rules.py 73a91f4 
  test/integration/component/test_eip_elb.py 4c8dcbe 
  test/integration/component/test_network_offering.py c1a518b 
  test/integration/component/test_project_configs.py d5ce9d6 
  test/integration/component/test_project_limits.py 8f7c128 
  test/integration/component/test_project_resources.py 27452be 
  test/integration/component/test_project_usage.py 4561576 
  test/integration/component/test_projects.py 811d092 
  test/integration/component/test_resource_limits.py cd007f1 
  test/integration/component/test_routers.py a65c5c3 
  test/integration/component/test_security_groups.py 13a87b6 
  test/integration/component/test_templates.py e9be63d 
  test/integration/component/test_usage.py 34dbc37 
  test/integration/component/test_volumes.py 5819001 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java c1139ee 
  vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 

Diff: https://reviews.apache.org/r/9769/diff/


Testing
-------

done


Thanks,

SrikanteswaraRao Talluri


Re: Review Request: Fix the integration scripts for nose import and ostypeid corrections

Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9769/#review17465
-----------------------------------------------------------


Think you may have hit other files while creating the patch. Like the vmware and docs stuff. Can you clean that up and upload a fresh patch?

Thanks

- Prasanna Santhanam


On March 6, 2013, 6:42 a.m., SrikanteswaraRao Talluri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9769/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 6:42 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> 
>   Fix the integration scripts for nose import and ostypeid corrections
> 
>     from nose.plugins.attrib import attr
> 
>     "ostype": 'CentOS 5.3 (64-bit)',
> 
>             template = get_template(
>                                 cls.api_client,
>                                 cls.zone.id,
>                                 cls.services["ostype"]
>                                 )
> 
> 
> This addresses bug CLOUDSTACK-1530.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/add-remove-nic.xml PRE-CREATION 
>   docs/en-US/added-API-commands-4-1.xml f635e9d 
>   docs/en-US/whats-new.xml 29ae1f6 
>   server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java 5d0b01c 
>   test/integration/component/test_accounts.py d0b4434 
>   test/integration/component/test_allocation_states.py 006f879 
>   test/integration/component/test_blocker_bugs.py cc5da0a 
>   test/integration/component/test_egress_rules.py 73a91f4 
>   test/integration/component/test_eip_elb.py 4c8dcbe 
>   test/integration/component/test_network_offering.py c1a518b 
>   test/integration/component/test_project_configs.py d5ce9d6 
>   test/integration/component/test_project_limits.py 8f7c128 
>   test/integration/component/test_project_resources.py 27452be 
>   test/integration/component/test_project_usage.py 4561576 
>   test/integration/component/test_projects.py 811d092 
>   test/integration/component/test_resource_limits.py cd007f1 
>   test/integration/component/test_routers.py a65c5c3 
>   test/integration/component/test_security_groups.py 13a87b6 
>   test/integration/component/test_templates.py e9be63d 
>   test/integration/component/test_usage.py 34dbc37 
>   test/integration/component/test_volumes.py 5819001 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java c1139ee 
>   vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 
> 
> Diff: https://reviews.apache.org/r/9769/diff/
> 
> 
> Testing
> -------
> 
> done
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>


Re: Review Request: Fix the integration scripts for nose import and ostypeid corrections

Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9769/#review17466
-----------------------------------------------------------

Ship it!


9342f56 (master) 

Thanks

- Prasanna Santhanam


On March 6, 2013, 6:56 a.m., SrikanteswaraRao Talluri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9769/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 6:56 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Description
> -------
> 
> 
>   Fix the integration scripts for nose import and ostypeid corrections
> 
>     from nose.plugins.attrib import attr
> 
>     "ostype": 'CentOS 5.3 (64-bit)',
> 
>             template = get_template(
>                                 cls.api_client,
>                                 cls.zone.id,
>                                 cls.services["ostype"]
>                                 )
> 
> 
> This addresses bug CLOUDSTACK-1530.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_accounts.py d0b4434 
>   test/integration/component/test_allocation_states.py 006f879 
>   test/integration/component/test_blocker_bugs.py cc5da0a 
>   test/integration/component/test_egress_rules.py 73a91f4 
>   test/integration/component/test_eip_elb.py 4c8dcbe 
>   test/integration/component/test_network_offering.py c1a518b 
>   test/integration/component/test_project_configs.py d5ce9d6 
>   test/integration/component/test_project_limits.py 8f7c128 
>   test/integration/component/test_project_resources.py 27452be 
>   test/integration/component/test_project_usage.py 4561576 
>   test/integration/component/test_projects.py 811d092 
>   test/integration/component/test_resource_limits.py cd007f1 
>   test/integration/component/test_routers.py a65c5c3 
>   test/integration/component/test_security_groups.py 13a87b6 
>   test/integration/component/test_templates.py e9be63d 
>   test/integration/component/test_usage.py 34dbc37 
>   test/integration/component/test_volumes.py 5819001 
> 
> Diff: https://reviews.apache.org/r/9769/diff/
> 
> 
> Testing
> -------
> 
> done
> 
> 
> Thanks,
> 
> SrikanteswaraRao Talluri
> 
>


Re: Review Request: Fix the integration scripts for nose import and ostypeid corrections

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9769/
-----------------------------------------------------------

(Updated March 6, 2013, 6:56 a.m.)


Review request for cloudstack and Prasanna Santhanam.


Changes
-------

corrected the diff file


Description
-------


  Fix the integration scripts for nose import and ostypeid corrections

    from nose.plugins.attrib import attr

    "ostype": 'CentOS 5.3 (64-bit)',

            template = get_template(
                                cls.api_client,
                                cls.zone.id,
                                cls.services["ostype"]
                                )


This addresses bug CLOUDSTACK-1530.


Diffs (updated)
-----

  test/integration/component/test_accounts.py d0b4434 
  test/integration/component/test_allocation_states.py 006f879 
  test/integration/component/test_blocker_bugs.py cc5da0a 
  test/integration/component/test_egress_rules.py 73a91f4 
  test/integration/component/test_eip_elb.py 4c8dcbe 
  test/integration/component/test_network_offering.py c1a518b 
  test/integration/component/test_project_configs.py d5ce9d6 
  test/integration/component/test_project_limits.py 8f7c128 
  test/integration/component/test_project_resources.py 27452be 
  test/integration/component/test_project_usage.py 4561576 
  test/integration/component/test_projects.py 811d092 
  test/integration/component/test_resource_limits.py cd007f1 
  test/integration/component/test_routers.py a65c5c3 
  test/integration/component/test_security_groups.py 13a87b6 
  test/integration/component/test_templates.py e9be63d 
  test/integration/component/test_usage.py 34dbc37 
  test/integration/component/test_volumes.py 5819001 

Diff: https://reviews.apache.org/r/9769/diff/


Testing
-------

done


Thanks,

SrikanteswaraRao Talluri