[GitHub] [iceberg-docs] jamie-tabular commented on a diff in pull request #91: Replace themes with a single "iceberg-theme" that's shared by landing-page and docs site

[GitBox <gi...@apache.org>]

jamie-tabular commented on code in PR #91:
URL: https://github.com/apache/iceberg-docs/pull/91#discussion_r902849236


##########
iceberg-theme/static/css/iceberg-theme.css:
##########
@@ -241,32 +250,86 @@ h4:hover a { visibility: visible}
     display: grid;
     grid-template-columns: 5fr 1fr;
     grid-gap: 1rem;
+    height: 100vh;
+    width: 100vw;
+    padding-top: 1rem;
+    overflow-y: scroll;
+}
+
+div.sidebar {
+    text-decoration: none;
+    left: 0;
+    top: 0;
+    overflow-y: scroll;
+    background-color:#FFF;
+    display: block;
+    font-size: 16px;
+    min-width: 15rem;
+    list-style-type: none;
+}
+
+.sidebar ul {
+    text-decoration: none;
+    list-style: none;
+}
+
+.sidebar li a {
+    color: black;
+}
+
+.sidebar li a:hover {
+    color: #2879BE;
+}
+
+#active {
+    color: #2879BE;
+}
+
+i.fa.fa-chevron-right {
+ float: right;
+}
+
+i.fa.fa-chevron-down {
+ float: right;

Review Comment:
   This isn't a major concern but I would steer clear of `floats` if possible and use flexbox instead. `display: flex; justify-content: flex-end;`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org