You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/12 18:27:55 UTC
[GitHub] Roshrini commented on a change in pull request #14121: ONNX export:
Support equal length splits
Roshrini commented on a change in pull request #14121: ONNX export: Support equal length splits
URL: https://github.com/apache/incubator-mxnet/pull/14121#discussion_r256086709
##########
File path: python/mxnet/contrib/onnx/mx2onnx/export_onnx.py
##########
@@ -262,17 +262,18 @@ def create_onnx_graph_proto(self, sym, params, in_shape, in_type, verbose=False)
# If converted node is NodeProto, add it in processed nodes list
elif isinstance(converted_node, NodeProto):
onnx_processed_nodes.append(converted_node)
- node_name = converted_node.name if converted_node.name else converted_node.output[0]
- if node_name in graph_outputs:
- onnx_processed_outputs.append(
- make_tensor_value_info(
- name=node_name,
- elem_type=in_type,
- shape=graph_outputs[node_name]
+ node_names = list(converted_node.output)
+ for nodename in node_names:
Review comment:
Can you add code comments here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services