You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/06 18:03:56 UTC

[GitHub] [tvm] tkonolige opened a new pull request #7801: [FIX] Make HashCombine stable across platforms

tkonolige opened a new pull request #7801:
URL: https://github.com/apache/tvm/pull/7801


   PR #7605 inadvertatly broke cross platform hashing when when it switched size_t to uint64_t. This cause a different specialization of HashCombine to be used. Unfortunately the new specialization used std::hash which is
   implementation dependent. I've added tests to make sure this doesn't happen again.
   
   @tmoreau89 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 commented on pull request #7801: [FIX] Make HashCombine stable across platforms

Posted by GitBox <gi...@apache.org>.

tmoreau89 commented on pull request #7801:
URL: https://github.com/apache/tvm/pull/7801#issuecomment-814588273


   Thank you @tkonolige @mdw-octoml @michalpiszczek, the PR has been merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 merged pull request #7801: [FIX] Make HashCombine stable across platforms

Posted by GitBox <gi...@apache.org>.

tmoreau89 merged pull request #7801:
URL: https://github.com/apache/tvm/pull/7801


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org