You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/10 05:50:46 UTC
[GitHub] [flink] zhengcanbin opened a new pull request #11360:
[FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
zhengcanbin opened a new pull request #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360
## What is the purpose of the change
1. Currently, we expose some ports via the main Container of the JobManager and the TaskManager, but we forget to name those ports so that people could be confused because there is no description of the port usage. This PR proposes to explicitly name the ports in the Container to help people understand the usage of those ports.
2. Since the port name in the Container must be less than 15 characters, meanwhile we prefer to keep the port name consistent between the Container and the Service, so this PR also makes little change to the existing name of the corresponding ports in the Service. This is a minor change that rarely requires modification from user perspective.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11360:
[FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360#issuecomment-596920933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152578249",
"triggerID" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"triggerType" : "PUSH"
}, {
"hash" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6110",
"triggerID" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0037e8816fb00f1a6d3f06a32b7acace3298e009 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152578249) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6110)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11360:
[FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360#issuecomment-596920933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152578249",
"triggerID" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"triggerType" : "PUSH"
}, {
"hash" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6110",
"triggerID" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0037e8816fb00f1a6d3f06a32b7acace3298e009 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152578249) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6110)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun merged pull request #11360: [FLINK-16508][k8s]
Name the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
TisonKun merged pull request #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11360: [FLINK-16508][k8s]
Name the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360#issuecomment-599329666
> Thanks for your contribution @zhengcanbin ! It seems we should also include this improvement in 1.10, would you like to open a PR towards 1.10?
Thanks for the review @TisonKun! I will open a PR towards 1.10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11360: [FLINK-16508][k8s] Name
the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360#issuecomment-596916787
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0037e8816fb00f1a6d3f06a32b7acace3298e009 (Tue Mar 10 05:53:56 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11360:
[FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360#issuecomment-596920933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/152578249",
"triggerID" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"triggerType" : "PUSH"
}, {
"hash" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6110",
"triggerID" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0037e8816fb00f1a6d3f06a32b7acace3298e009 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/152578249) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6110)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #11360: [FLINK-16508][k8s] Name
the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360#issuecomment-599311569
Thanks for your contribution @zhengcanbin ! It seems we should also include this improvement in 1.10, would you like to open a PR towards 1.10?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11360: [FLINK-16508][k8s]
Name the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360#issuecomment-596995569
cc @TisonKun. Looking forward to your feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11360: [FLINK-16508][k8s] Name
the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360#issuecomment-596920933
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0037e8816fb00f1a6d3f06a32b7acace3298e009",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0037e8816fb00f1a6d3f06a32b7acace3298e009 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11360: [FLINK-16508][k8s]
Name the ports exposed by the main Container in Pod
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11360: [FLINK-16508][k8s] Name the ports exposed by the main Container in Pod
URL: https://github.com/apache/flink/pull/11360#issuecomment-599175563
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services