You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/05/17 23:37:28 UTC
[GitHub] [arrow] felipecrv opened a new pull request, #35657: MINOR: [C++] Add mising pragma-once
felipecrv opened a new pull request, #35657:
URL: https://github.com/apache/arrow/pull/35657
### Rationale for this change
The C compilation model.
### What changes are included in this PR?
Adding a `#pragma once` that I forgot to add when I created this header.
### Are these changes tested?
N/A.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35657: MINOR: [C++] Add mising pragma-once
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35657:
URL: https://github.com/apache/arrow/pull/35657#issuecomment-1556043770
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bfb82668901d406892ce069b3eb4b859...d78ef390289b4d15a97b41ab6bbda307/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35657: MINOR: [C++] Add mising pragma-once
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35657:
URL: https://github.com/apache/arrow/pull/35657#issuecomment-1568183173
@raulcd I don't think this is required if it doesn't fix any breakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #35657: MINOR: [C++] Add mising pragma-once
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #35657:
URL: https://github.com/apache/arrow/pull/35657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #35657: MINOR: [C++] Add mising pragma-once
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #35657:
URL: https://github.com/apache/arrow/pull/35657#issuecomment-1568036042
Hi @felipecrv , I see this is tagged as 12.0.1 but doesn't have an associated issue. Our cherry-pick scripts can't pick issues for minor releases automatically if there is no a linked GitHub issue. I can cherry-pick this manually but is this required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35657: MINOR: [C++] Add mising pragma-once
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35657:
URL: https://github.com/apache/arrow/pull/35657#issuecomment-1556043658
Benchmark runs are scheduled for baseline = 6bd00508116edea5afcdc4e3e11cd9fa789b70a3 and contender = dd33cabdc40fc28f85e6f80bbf572f8ddfeae9ef. dd33cabdc40fc28f85e6f80bbf572f8ddfeae9ef is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/814b1e69a9c0417e87304aed6f42dd1b...8a727439ae634a64a45d3fcba5629508/)
[Finished :arrow_down:0.24% :arrow_up:0.06%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/0cbc622326074df4abc3aef4e7fc4946...35fc929c69664716a1228eedfcc238f3/)
[Finished :arrow_down:0.65% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bfb82668901d406892ce069b3eb4b859...d78ef390289b4d15a97b41ab6bbda307/)
[Finished :arrow_down:0.42% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8343ad670a3a4134b5b55a181496b5a1...991679fb50a1429aaffdcc46c9b2e84e/)
Buildkite builds:
[Finished] [`dd33cabd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2896)
[Finished] [`dd33cabd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2932)
[Finished] [`dd33cabd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2897)
[Finished] [`dd33cabd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2922)
[Finished] [`6bd00508` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2895)
[Finished] [`6bd00508` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2931)
[Finished] [`6bd00508` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2896)
[Finished] [`6bd00508` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2921)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] felipecrv commented on pull request #35657: MINOR: [C++] Add mising pragma-once
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #35657:
URL: https://github.com/apache/arrow/pull/35657#issuecomment-1553122079
CI failures are unrelated. @westonpace @pitrou can it be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org