[jira] [Commented] (MINIFICPP-694) Ensure that processor consist of proper phases

["Arpad Boda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817818#comment-16817818 ] 

Arpad Boda commented on MINIFICPP-694:
--------------------------------------

[~phrocker]: I started working on this last week, did most of the things needed, although I'm less and less sure about this being the right way forward. The two main concerns I have: 

-OnSchedule's main purpose is to get and store value of static properties, but those are not supported for custom processors. Doing so would require further API extension to be able to register them, which is definitely possible, but I don't really see a lot of value added by doing this. 

-Communication. Whatever we do "onSchedule" should result in some data accessible in "onTrigger", although in pure C the callbacks cannot be member functions, we don't have lambda captures, etc... So communication can happen by either accessing some global structures or extending the callback signatures with some additional argument. The latter is a bit better, but still seems to be a bit overcomplicated in my opinion. 

> Ensure that processor consist of proper phases
> ----------------------------------------------
>
>                 Key: MINIFICPP-694
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-694
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Mr TheSegfault
>            Assignee: Arpad Boda
>            Priority: Major
>              Labels: nanofi
>             Fix For: 0.7.0
>
>
> Ensure that processor consist of proper phases – such as "onSchedule" – that is when it is scheduled and onTrigger, when it is invoked. Ensure consistent naming and that custom processors provide this capability. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)