[GitHub] [shardingsphere] maxh4 commented on issue #9381: sharding-jdbc-spring-boot-starter auto-configuration class better to rename

[GitBox <gi...@apache.org>]

maxh4 commented on issue #9381:
URL: https://github.com/apache/shardingsphere/issues/9381#issuecomment-774846438


   Hi @tristaZero ,
   
   I didn't mean any conflicts. Just a naming strategy suggestion.
   
   My project is in this structure:
   |-RootProject
     \-CommonModule
     \-ServiceModule1
     \-ServiceModule2
   
   ServiceModules are all referencing the CommonModule, so that I can extract some common configurations to avoid redundant code.
   Then I also need to write some tests in each module, so I have excluded the auto-configuration classes for features in Common, then import back in ServiceModules. This can start spring and run tests without configuration properties declared in the yaml file.
   
   For other AutoConfiguration classes from the features I used, they are naming like:
   SecurityAutoConfiguration.class,
   DruidDataSourceAutoConfigure.class,
   DataSourceAutoConfiguration.class,
   RabbitAutoConfiguration.class
   
   So here I suggest renaming the sharding sphere data source auto-configuration boot class to avoid confusions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org