[GitHub] guacamole-client pull request #351: GUACAMOLE-683: Add OpenID support in Doc...

[mike-jumper <gi...@git.apache.org>]

Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/351#discussion_r247040348
  
    --- Diff: guacamole-docker/bin/start.sh ---
    @@ -404,6 +404,42 @@ END
         ln -s /opt/guacamole/radius/guacamole-auth-*.jar "$GUACAMOLE_EXT"
     }
     
    +## Adds properties to guacamole.properties which select the OPENID
    +## authentication provider, and configure it to connect to the specified OPENID
    +## provider.
    +##
    +associate_openid() {
    +
    +    # Verify required parameters are present
    +    if [ -z "$OPENID_AUTHORIZATION_ENDPOINT" ] || \
    +       [ -z "$OPENID_JWKS_ENDPOINT" ]          || \
    +       [ -z "$OPENID_ISSUER" ]                 || \
    +       [ -z "$OPENID_CLIENT_ID" ]              || \          
    +       [ -z "$OPENID_REDIRECT_URI" ]
    +    then
    +        cat <<END
    +FATAL: Missing required environment variables to setup openid authentication.
    +-------------------------------------------------------------------------------
    +END
    --- End diff --
    
    The specifics of the error should be logged. For example, take a look at the error displayed if required variables are missing for MySQL auth:
    
    https://github.com/apache/guacamole-client/blob/78f1ae1b4eac25501d532ddee94fd1d8588e56dc/guacamole-docker/bin/start.sh#L131-L143


---