You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2009/12/30 04:16:37 UTC

svn commit: r894536 - /jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java

Author: sebb
Date: Wed Dec 30 03:16:04 2009
New Revision: 894536

URL: http://svn.apache.org/viewvc?rev=894536&view=rev
Log:
Tidy code

Modified:
    jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java

Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java?rev=894536&r1=894535&r2=894536&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java Wed Dec 30 03:16:04 2009
@@ -53,37 +53,31 @@
      * class to do its work --------------------------------------------
      */
 
-    protected URL WSDLURL = null;
+    private URL WSDLURL = null;
 
-    protected URLConnection CONN = null;
+    private URLConnection CONN = null;
 
-    protected Document WSDLDOC = null;
+    private Document WSDLDOC = null;
 
-    protected String SOAPBINDING = null;
+    private String SOAPBINDING = null;
 
-    public String BINDNAME = null;
+    private URL bindingURL = null;
 
-    protected URL bindingURL = null;
+    private Object[] SOAPOPS = null;
 
-    protected Object[] SOAPOPS = null;
+    private final HashMap<String, String> ACTIONS = new HashMap<String, String>();
 
-    protected HashMap<String, String> ACTIONS = new HashMap<String, String>();
-
-    protected AuthManager AUTH = null;
+    private final AuthManager AUTH;
 
     /**
      * Default constructor takes a string URL
      */
     public WSDLHelper(String url) throws MalformedURLException {
-        try {
-            WSDLURL = new URL(url);
-        } catch (MalformedURLException exception) {
-            throw exception;
-        }
+        this(url, null);
     }
 
     public WSDLHelper(String url, AuthManager auth) throws MalformedURLException {
-        this(url);
+        WSDLURL = new URL(url);
         this.AUTH = auth;
     }
 
@@ -317,8 +311,7 @@
             Element nd = (Element) bindings.item(idx);
             NodeList slist = nd.getElementsByTagName(soapBind);
             if (slist.getLength() > 0) {
-                // NOTUSED Element soapbind = (Element) slist.item(0);
-                this.BINDNAME = nd.getAttribute("name");
+                nd.getAttribute("name");
                 list.add(nd);
             }
         }



---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org