You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ionel Corneliu Gog (JIRA)" <ji...@apache.org> on 2011/07/13 02:13:00 UTC
[jira] [Created] (THRIFT-1237) Update
Update
-------
Key: THRIFT-1237
URL: https://issues.apache.org/jira/browse/THRIFT-1237
Project: Thrift
Issue Type: Improvement
Components: Java - Library
Affects Versions: 0.7
Reporter: Ionel Corneliu Gog
The java fb303 monitoring interface does not have several methods that are present in the cpp interface.
I am adding incrementCounter(String key, long increment) and setCounter(String key, long value).
On top of that I am changing the return of getStatus to an i32 value instead of the fb_status enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1237) Java fb303 missing some methods
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1237.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.7
Assignee: Ionel Corneliu Gog
Cool, I just committed this. Thanks for the patch!
> Java fb303 missing some methods
> -------------------------------
>
> Key: THRIFT-1237
> URL: https://issues.apache.org/jira/browse/THRIFT-1237
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.7
> Reporter: Ionel Corneliu Gog
> Assignee: Ionel Corneliu Gog
> Fix For: 0.7
>
> Attachments: add_java_counters.patch
>
>
> The java fb303 monitoring interface does not have several methods that are present in the cpp interface.
> I am adding incrementCounter(String key, long increment) and setCounter(String key, long value).
> On top of that I am changing the return of getStatus to an i32 value instead of the fb_status enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1237) Java fb303 missing some methods
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-1237:
----------------------------------
Summary: Java fb303 missing some methods (was: Update )
> Java fb303 missing some methods
> -------------------------------
>
> Key: THRIFT-1237
> URL: https://issues.apache.org/jira/browse/THRIFT-1237
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.7
> Reporter: Ionel Corneliu Gog
> Attachments: add_java_counters.patch
>
>
> The java fb303 monitoring interface does not have several methods that are present in the cpp interface.
> I am adding incrementCounter(String key, long increment) and setCounter(String key, long value).
> On top of that I am changing the return of getStatus to an i32 value instead of the fb_status enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1237) Java fb303 missing some methods
Posted by "Ionel Corneliu Gog (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ionel Corneliu Gog updated THRIFT-1237:
---------------------------------------
Attachment: (was: add_java_counters.patch)
> Java fb303 missing some methods
> -------------------------------
>
> Key: THRIFT-1237
> URL: https://issues.apache.org/jira/browse/THRIFT-1237
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.7
> Reporter: Ionel Corneliu Gog
> Attachments: add_java_counters.patch
>
>
> The java fb303 monitoring interface does not have several methods that are present in the cpp interface.
> I am adding incrementCounter(String key, long increment) and setCounter(String key, long value).
> On top of that I am changing the return of getStatus to an i32 value instead of the fb_status enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1237) Update
Posted by "Ionel Corneliu Gog (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ionel Corneliu Gog updated THRIFT-1237:
---------------------------------------
Attachment: add_java_counters.patch
> Update
> -------
>
> Key: THRIFT-1237
> URL: https://issues.apache.org/jira/browse/THRIFT-1237
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.7
> Reporter: Ionel Corneliu Gog
> Attachments: add_java_counters.patch
>
>
> The java fb303 monitoring interface does not have several methods that are present in the cpp interface.
> I am adding incrementCounter(String key, long increment) and setCounter(String key, long value).
> On top of that I am changing the return of getStatus to an i32 value instead of the fb_status enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1237) Java fb303 missing some methods
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064736#comment-13064736 ]
Bryan Duxbury commented on THRIFT-1237:
---------------------------------------
I am confused about why you chose to edit the thrift file? Isn't that supposed to be a fundamentally unchanged part of fb303?
> Java fb303 missing some methods
> -------------------------------
>
> Key: THRIFT-1237
> URL: https://issues.apache.org/jira/browse/THRIFT-1237
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.7
> Reporter: Ionel Corneliu Gog
> Attachments: add_java_counters.patch
>
>
> The java fb303 monitoring interface does not have several methods that are present in the cpp interface.
> I am adding incrementCounter(String key, long increment) and setCounter(String key, long value).
> On top of that I am changing the return of getStatus to an i32 value instead of the fb_status enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1237) Java fb303 missing some methods
Posted by "Ionel Corneliu Gog (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ionel Corneliu Gog updated THRIFT-1237:
---------------------------------------
Attachment: add_java_counters.patch
> Java fb303 missing some methods
> -------------------------------
>
> Key: THRIFT-1237
> URL: https://issues.apache.org/jira/browse/THRIFT-1237
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.7
> Reporter: Ionel Corneliu Gog
> Attachments: add_java_counters.patch
>
>
> The java fb303 monitoring interface does not have several methods that are present in the cpp interface.
> I am adding incrementCounter(String key, long increment) and setCounter(String key, long value).
> On top of that I am changing the return of getStatus to an i32 value instead of the fb_status enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1237) Java fb303 missing some methods
Posted by "Ionel Corneliu Gog (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064780#comment-13064780 ]
Ionel Corneliu Gog commented on THRIFT-1237:
--------------------------------------------
We had some backward compatibility issues at Facebook, but we will solve them in a different way. I updated the patch so that it only includes the new counters.
> Java fb303 missing some methods
> -------------------------------
>
> Key: THRIFT-1237
> URL: https://issues.apache.org/jira/browse/THRIFT-1237
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.7
> Reporter: Ionel Corneliu Gog
> Attachments: add_java_counters.patch
>
>
> The java fb303 monitoring interface does not have several methods that are present in the cpp interface.
> I am adding incrementCounter(String key, long increment) and setCounter(String key, long value).
> On top of that I am changing the return of getStatus to an i32 value instead of the fb_status enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1237) Java fb303 missing some methods
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070052#comment-13070052 ]
Hudson commented on THRIFT-1237:
--------------------------------
Integrated in Thrift #193 (See [https://builds.apache.org/job/Thrift/193/])
THRIFT-1237. contrib: Java fb303 missing some methods
Added counters to FacebookBase.
Patch: Ionel Corneliu Gog
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1146484
Files :
* /thrift/trunk/contrib/fb303/java/src/FacebookBase.java
> Java fb303 missing some methods
> -------------------------------
>
> Key: THRIFT-1237
> URL: https://issues.apache.org/jira/browse/THRIFT-1237
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.7
> Reporter: Ionel Corneliu Gog
> Assignee: Ionel Corneliu Gog
> Fix For: 0.7
>
> Attachments: add_java_counters.patch
>
>
> The java fb303 monitoring interface does not have several methods that are present in the cpp interface.
> I am adding incrementCounter(String key, long increment) and setCounter(String key, long value).
> On top of that I am changing the return of getStatus to an i32 value instead of the fb_status enum.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira