You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/10/06 12:49:12 UTC
[GitHub] [incubator-streampark] 1996fanrui opened a new pull request, #1749: [Feature] Simplify restartStrategy related configuration
1996fanrui opened a new pull request, #1749:
URL: https://github.com/apache/incubator-streampark/pull/1749
## What problem does this PR solve?
Issue Number: close #1743
Problem Summary:
Click #1739 to get detailed background.
Simplify restartStrategy related configuration.
| StreamPark Configuration | Flink Configuration | Flink 1.12 doc | Flink 1.15 doc |
| --- | --- | --- | --- |
| flink.restart-strategy.value | restart-strategy | https://nightlies.apache.org/flink/flink-docs-release-1.12/deployment/config.html#restart-strategy | https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/deployment/config/#restart-strategy |
| flink.restart-strategy.failure-rate.max-failures-per-interval | restart-strategy.failure-rate.max-failures-per-interval | https://nightlies.apache.org/flink/flink-docs-release-1.12/deployment/config.html#restart-strategy-failure-rate-max-failures-per-interval | https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/deployment/config/#restart-strategy-failure-rate-max-failures-per-interval |
| flink.restart-strategy.failure-rate.failure-rate-interval | restart-strategy.failure-rate.failure-rate-interval | https://nightlies.apache.org/flink/flink-docs-release-1.12/deployment/config.html#restart-strategy-failure-rate-failure-rate-interval | https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/deployment/config/#restart-strategy-failure-rate-failure-rate-interval |
| flink.restart-strategy.failure-rate.delay | restart-strategy.failure-rate.delay | https://nightlies.apache.org/flink/flink-docs-release-1.12/deployment/config.html#restart-strategy-failure-rate-delay | https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/deployment/config/#restart-strategy-failure-rate-delay |
| flink.restart-strategy.fixed-delay.attempts | restart-strategy.fixed-delay.attempts | https://nightlies.apache.org/flink/flink-docs-release-1.12/deployment/config.html#restart-strategy-fixed-delay-attempts | https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/deployment/config/#restart-strategy-fixed-delay-attempts |
| flink.restart-strategy.fixed-delay.delay | restart-strategy.fixed-delay.delay | https://nightlies.apache.org/flink/flink-docs-release-1.12/deployment/config.html#restart-strategy-fixed-delay-delay | https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/deployment/config/#restart-strategy-fixed-delay-delay |
## What is changed and how it works?
Proposal: [xxx](url) <!-- REMOVE this line if not applicable -->
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/streampark/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
## Purpose of this pull request
Simplify restartStrategy related configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #1749: [Feature] Simplify restartStrategy related configuration
Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1749:
URL: https://github.com/apache/incubator-streampark/pull/1749#issuecomment-1270274420
> > hi fanrui: It looks good, Thanks you for your contribution, BTW the [document](https://streampark.apache.org/docs/development/config#configuration-file) also needs to be updated
>
> Good idea, I create an issue #1751 , I will update the doc when all configurations are done.
ok. Thanks for your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #1749: [Feature] Simplify restartStrategy related configuration
Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #1749:
URL: https://github.com/apache/incubator-streampark/pull/1749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #1749: [Feature] Simplify restartStrategy related configuration
Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1749:
URL: https://github.com/apache/incubator-streampark/pull/1749#issuecomment-1270247915
hi fanrui:
It looks good, Thanks you for your contribution, BTW the [document](https://streampark.apache.org/docs/development/config#configuration-file) also needs to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] 1996fanrui commented on pull request #1749: [Feature] Simplify restartStrategy related configuration
Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #1749:
URL: https://github.com/apache/incubator-streampark/pull/1749#issuecomment-1270270775
> hi fanrui: It looks good, Thanks you for your contribution, BTW the [document](https://streampark.apache.org/docs/development/config#configuration-file) also needs to be updated
Good idea, I create an issue #1751 , I will update the doc when all configurations are done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org