You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by riknoll <gi...@git.apache.org> on 2016/02/17 03:25:06 UTC
[GitHub] cordova-medic pull request: Revert commits 7682cd7 and 90d06a3
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-medic/pull/79
Revert commits 7682cd7 and 90d06a3
This reverts commits 7682cd7205f153bc252ab8e1ef445169d34e11c2
and 90d06a39cbaf9313edae0fa3cc63a63003b65553 because they were
causing the cordova-android build slaves to fail running tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-medic CB-10510undo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit f1662f3469709555bee97fcfb459a3886fa58fb4
Author: riknoll <ri...@gmail.com>
Date: 2016-02-17T02:11:03Z
Revert commits 7682cd7 and 90d06a3
This reverts commits 7682cd7205f153bc252ab8e1ef445169d34e11c2
and 90d06a39cbaf9313edae0fa3cc63a63003b65553 because they were
causing the cordova-android build slaves to fail running tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: Revert commits 7682cd7 and 90d06a3
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/79#issuecomment-185016544
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: Revert commits 7682cd7 and 90d06a3
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/79#issuecomment-184983527
The issue here was that we currently don't have any way to test medic with buildbot prior to pushing. These commits test fine locally, but due to some quirk in buildbot caused it to start throwing exceptions on Windows and timing out builds on OSX. @dblotsky hypothesized that it may have to do with child processes being spawned and never killed. I'd have to guess that the child process in this case is the emulator, which we can't simply kill or we'll lose the log step.
This requires some investigation and is unlikely to be a quick fix so I am suggesting reverting the commit for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: Revert commits 7682cd7 and 90d06a3
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-medic/pull/79#issuecomment-184981066
@rakatyal check it out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: Revert commits 7682cd7 and 90d06a3
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: Revert commits 7682cd7 and 90d06a3
Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-medic/pull/79#issuecomment-184982255
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org