You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/11/27 09:42:21 UTC
[GitHub] [lucene] mocobeta opened a new pull request #481: set group to 'run' benchmark task
mocobeta opened a new pull request #481:
URL: https://github.com/apache/lucene/pull/481
A spin-off from #479.
```
./gradlew tasks
Utility launchers tasks
-----------------------
run - Run a perf test (optional: -PtaskAlg=conf/your-algorithm-file -PmaxHeapSize=1G)
```
It seems the description of the "run" task in the luke sub-project was disappeared. I think this is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #481: set group to 'run' benchmark task
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980810486
It's not related to the task group definition though,
```
./gradlew -p lucene/benchmark/ run
```
seems to fail without proper data preparation. Before the very minor change I added here, the task description or help could/should be augmented. There is benchmark/README.enwiki, this seems to be a bit obsoleted (it mentions ant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #481: set group to 'run' benchmark task
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980814245
Ok I found the datasets download tasks.
`gradlew tasks` now shows:
```
Utility launchers tasks
-----------------------
run - Run a perf test (optional: -PtaskAlg=conf/your-algorithm-file -PmaxHeapSize=1G). Before running this, you need to download the dataset the benchmark run against (e.g., by getReuters task). See dataset download tasks for more details.
```
(Having `gradlew :helpBenchmark` could also be in there, if such doc is maintainable.)
I think it would be more helpful for the majority of developers to show that in the first place, instead of showing luke module's run task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #481: set group to 'run' benchmark task
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980646469
I think the context here can be provided via gradle's built-in mechanisms. This (gradlew :lucene:luke:run) is clearer to me than having differently named tasks for each type of runnable target. This said, I don't care that much. You could even add an alias task that just depends on run and keep both...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta edited a comment on pull request #481: set group to 'run' benchmark task
Posted by GitBox <gi...@apache.org>.
mocobeta edited a comment on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980814245
Ok I found the datasets download tasks.
`gradlew tasks` now shows:
```
Utility launchers tasks
-----------------------
run - Run a perf test (optional: -PtaskAlg=conf/your-algorithm-file -PmaxHeapSize=1G). Before running this, you need to download the dataset the benchmark run against (e.g., by getReuters task). See dataset download tasks for more details.
```
(`gradlew :helpBenchmark` could also be in there, if such doc is maintainable.)
I think it would be more helpful for the majority of developers to show that in the first place, than showing the luke module's run task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta merged pull request #481: set group to 'run' benchmark task
Posted by GitBox <gi...@apache.org>.
mocobeta merged pull request #481:
URL: https://github.com/apache/lucene/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #481: set group to 'run' benchmark task
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #481:
URL: https://github.com/apache/lucene/pull/481#issuecomment-980585757
I understand sharing the same name between multiple tasks is perfectly fine; meanwhile, my feeling is it could also be a good convention to have well-distinguished names for context-specific tasks.
e.g.:
```
Utility launchers tasks
-----------------------
runBench - Run a perf test (optional: -PtaskAlg=conf/your-algorithm-file -PmaxHeapSize=1G)
runLuke - Launches (spawns) Luke directly from the build process.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org