You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/09 19:18:47 UTC
Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------
Review request for mesos and Bernd Mathiske.
Bugs: MESOS-4156
https://issues.apache.org/jira/browse/MESOS-4156
Repository: mesos
Description
-------
Speed up FetcherCache test cases by advance allocation_interval.
Diffs
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/43367/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review118439
-----------------------------------------------------------
Bad patch!
Reviews applied: [42696]
Failed command: ./support/apply-review.sh -n -r 42696
Error:
2016-02-09 19:18:10 URL:https://reviews.apache.org/r/42696/diff/raw/ [144206/144206] -> "42696.patch" [1]
Total errors found: 0
Checking 38 files
ERROR: Commit spanning multiple projects.
Please use separate commits for mesos, libprocess and stout.
Paths grouped by project:
mesos:
CHANGELOG
Makefile.am
configure.ac
docs/endpoints/files/browse.json.md
docs/endpoints/files/browse.md
docs/endpoints/files/debug.json.md
docs/endpoints/files/debug.md
docs/endpoints/files/download.json.md
docs/endpoints/files/download.md
docs/endpoints/files/read.json.md
docs/endpoints/files/read.md
docs/endpoints/index.md
docs/endpoints/logging/toggle.md
docs/endpoints/master/api/v1/scheduler.md
docs/endpoints/master/create-volumes.md
docs/endpoints/master/destroy-volumes.md
docs/endpoints/master/flags.md
docs/endpoints/master/frameworks.md
docs/endpoints/master/health.md
docs/endpoints/master/machine/down.md
docs/endpoints/master/machine/up.md
docs/endpoints/master/maintenance/schedule.md
docs/endpoints/master/maintenance/status.md
docs/endpoints/master/observe.md
docs/endpoints/master/quota.md
docs/endpoints/master/redirect.md
docs/endpoints/master/reserve.md
docs/endpoints/master/roles.json.md
docs/endpoints/master/roles.md
docs/endpoints/master/slaves.md
docs/endpoints/master/state-summary.md
docs/endpoints/master/state.json.md
docs/endpoints/master/state.md
docs/endpoints/master/tasks.json.md
docs/endpoints/master/tasks.md
docs/endpoints/master/teardown.md
docs/endpoints/master/unreserve.md
docs/endpoints/metrics/snapshot.md
docs/endpoints/monitor/statistics.json.md
docs/endpoints/monitor/statistics.md
docs/endpoints/profiler/start.md
docs/endpoints/profiler/stop.md
docs/endpoints/registrar/registry.md
docs/endpoints/slave/api/v1/executor.md
docs/endpoints/slave/flags.md
docs/endpoints/slave/health.md
docs/endpoints/slave/state.json.md
docs/endpoints/slave/state.md
docs/endpoints/system/stats.json.md
docs/endpoints/version.md
site/README.md
src/Makefile.am
src/examples/event_call_framework.cpp
src/examples/test_framework.cpp
src/examples/test_http_executor.cpp
src/launcher/executor.cpp
src/slave/containerizer/containerizer.hpp
src/slave/containerizer/mesos/containerizer.cpp
src/slave/containerizer/mesos/containerizer.hpp
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp
src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp
src/slave/http.cpp
src/slave/slave.cpp
src/tests/balloon_framework_test.sh
src/tests/containerizer/filesystem_isolator_tests.cpp
src/tests/containerizer/isolator_tests.cpp
src/tests/containerizer/launch_tests.cpp
src/tests/containerizer/memory_test_helper.cpp
src/tests/containerizer/mesos_containerizer_tests.cpp
src/tests/containerizer/ns_tests.cpp
src/tests/containerizer/port_mapping_tests.cpp
src/tests/containerizer/provisioner_appc_tests.cpp
src/tests/environment.cpp
src/tests/event_call_framework_test.sh
src/tests/examples_tests.cpp
src/tests/fetcher_cache_tests.cpp
src/tests/fetcher_tests.cpp
src/tests/health_check_tests.cpp
src/tests/mesos.cpp
src/tests/module.cpp
src/tests/module_tests.cpp
src/tests/no_executor_framework_test.sh
src/tests/oversubscription_tests.cpp
src/tests/persistent_volume_framework_test.sh
src/tests/script.cpp
src/tests/slave_tests.cpp
src/tests/test_framework_test.sh
src/tests/uri_fetcher_tests.cpp
src/tests/utils.cpp
src/tests/utils.hpp
support/atexit.sh
support/coverage.sh
support/docker_build.sh
support/generate-endpoint-help.py
support/hooks/commit-msg
support/release.sh
support/tag.sh
support/vote.sh
stout:
3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
Full log: https://builds.apache.org/job/mesos-reviewbot/11349/console
- Mesos ReviewBot
On Feb. 9, 2016, 6:30 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 6:30 p.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by Guangya Liu <gy...@gmail.com>.
> On 二月 10, 2016, 3:39 a.m., Guangya Liu wrote:
> > src/tests/fetcher_cache_tests.cpp, line 424
> > <https://reviews.apache.org/r/43367/diff/2/?file=1239195#file1239195line424>
> >
> > Can you introduce a new member variable named as `master flags` and get the allocation interval from `flags.allocation_interval`?
>
> haosdent huang wrote:
> How about use `DEFAULT_ALLOCATION_INTERVAL` here directly? So that we could move above
> ```
> masterFlags = CreateMasterFlags();
> Try<PID<Master>> master = StartMaster(masterFlags);
> ```
> as well.
+1, this is more simple, thanks ;-)
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review118563
-----------------------------------------------------------
On 二月 10, 2016, 1:42 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated 二月 10, 2016, 1:42 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
> On Feb. 10, 2016, 3:39 a.m., Guangya Liu wrote:
> > src/tests/fetcher_cache_tests.cpp, line 424
> > <https://reviews.apache.org/r/43367/diff/2/?file=1239195#file1239195line424>
> >
> > Can you introduce a new member variable named as `master flags` and get the allocation interval from `flags.allocation_interval`?
>
> haosdent huang wrote:
> How about use `DEFAULT_ALLOCATION_INTERVAL` here directly? So that we could move above
> ```
> masterFlags = CreateMasterFlags();
> Try<PID<Master>> master = StartMaster(masterFlags);
> ```
> as well.
>
> Guangya Liu wrote:
> +1, this is more simple, thanks ;-)
Thx, let me update.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review118563
-----------------------------------------------------------
On Feb. 10, 2016, 1:42 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 1:42 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
> On Feb. 10, 2016, 3:39 a.m., Guangya Liu wrote:
> > src/tests/fetcher_cache_tests.cpp, line 424
> > <https://reviews.apache.org/r/43367/diff/2/?file=1239195#file1239195line424>
> >
> > Can you introduce a new member variable named as `master flags` and get the allocation interval from `flags.allocation_interval`?
How about use `DEFAULT_ALLOCATION_INTERVAL` here directly? So that we could move above
```
masterFlags = CreateMasterFlags();
Try<PID<Master>> master = StartMaster(masterFlags);
```
as well.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review118563
-----------------------------------------------------------
On Feb. 10, 2016, 1:42 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 1:42 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review118563
-----------------------------------------------------------
src/tests/fetcher_cache_tests.cpp (lines 193 - 195)
<https://reviews.apache.org/r/43367/#comment179834>
Why update here? The `StartMaster` will call `CreateMasterFlags` if no paramter provided.
src/tests/fetcher_cache_tests.cpp (line 424)
<https://reviews.apache.org/r/43367/#comment179835>
Can you introduce a new member variable named as `master flags` and get the allocation interval from `flags.allocation_interval`?
- Guangya Liu
On 二月 10, 2016, 1:42 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated 二月 10, 2016, 1:42 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review118566
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42696, 43316, 43367]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 10, 2016, 1:42 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 1:42 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
> On Feb. 10, 2016, 4:12 a.m., Guangya Liu wrote:
> > src/tests/fetcher_cache_tests.cpp, line 64
> > <https://reviews.apache.org/r/43367/diff/3/?file=1239268#file1239268line64>
> >
> > Do you need the DEFAULT_ALLOCATION_INTERVAL namespace? `using mesos::internal::master::DEFAULT_ALLOCATION_INTERVAL;`
Yes, thank you very much.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review118576
-----------------------------------------------------------
On Feb. 10, 2016, 4:17 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 4:17 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review118576
-----------------------------------------------------------
src/tests/fetcher_cache_tests.cpp (line 64)
<https://reviews.apache.org/r/43367/#comment179848>
Do you need the DEFAULT_ALLOCATION_INTERVAL namespace? `using mesos::internal::master::DEFAULT_ALLOCATION_INTERVAL;`
- Guangya Liu
On 二月 10, 2016, 4:01 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated 二月 10, 2016, 4:01 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by reduce
allocation_interval.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119303
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42696, 43316, 43367]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 16, 2016, 11:42 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 11:42 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (984 ms)
> [ OK ] FetcherCacheTest.LocalCached (1750 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1043 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2723 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by reduce
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------
(Updated Feb. 16, 2016, 5:58 p.m.)
Review request for mesos and Bernd Mathiske.
Changes
-------
Rebase
Summary (updated)
-----------------
Speed up FetcherCache test cases by reduce allocation_interval.
Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628
Repository: mesos
Description (updated)
-------
Speed up FetcherCache test cases by reduce allocation_interval.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/43367/diff/
Testing
-------
Before
```
[ OK ] FetcherCacheTest.LocalUncached (943 ms)
[ OK ] FetcherCacheTest.LocalCached (1612 ms)
[ OK ] FetcherCacheTest.CachedFallback (906 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[ OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
```
After
```
[ OK ] FetcherCacheTest.LocalUncached (979 ms)
[ OK ] FetcherCacheTest.LocalCached (1510 ms)
[ OK ] FetcherCacheTest.CachedFallback (853 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[ OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```
Thanks,
haosdent huang
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------
(Updated Feb. 16, 2016, 5:55 p.m.)
Review request for mesos and Bernd Mathiske.
Summary (updated)
-----------------
Speed up FetcherCache test cases by advance allocation_interval.
Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628
Repository: mesos
Description
-------
Speed up FetcherCache test cases by advance allocation_interval.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/43367/diff/
Testing (updated)
-------
Before
```
[ OK ] FetcherCacheTest.LocalUncached (943 ms)
[ OK ] FetcherCacheTest.LocalCached (1612 ms)
[ OK ] FetcherCacheTest.CachedFallback (906 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[ OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
```
After
```
[ OK ] FetcherCacheTest.LocalUncached (979 ms)
[ OK ] FetcherCacheTest.LocalCached (1510 ms)
[ OK ] FetcherCacheTest.CachedFallback (853 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[ OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```
Thanks,
haosdent huang
Re: Review Request 43367: Speed up FetcherCache test cases by reduce
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------
(Updated Feb. 16, 2016, 11:42 a.m.)
Review request for mesos and Bernd Mathiske.
Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628
Repository: mesos
Description
-------
Speed up FetcherCache test cases by advance allocation_interval.
Diffs
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/43367/diff/
Testing
-------
Before this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1065 ms)
[ OK ] FetcherCacheTest.LocalCached (1728 ms)
[ OK ] FetcherCacheTest.CachedFallback (1105 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```
After this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (984 ms)
[ OK ] FetcherCacheTest.LocalCached (1750 ms)
[ OK ] FetcherCacheTest.CachedFallback (1043 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
[ OK ] FetcherCacheTest.SimpleEviction (2723 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
```
Thanks,
haosdent huang
Re: Review Request 43367: Speed up FetcherCache test cases by reduce
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------
(Updated Feb. 16, 2016, 11:41 a.m.)
Review request for mesos and Bernd Mathiske.
Changes
-------
Change the allocation interval to 500 ms.
Summary (updated)
-----------------
Speed up FetcherCache test cases by reduce allocation_interval.
Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618
Repository: mesos
Description
-------
Speed up FetcherCache test cases by advance allocation_interval.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/43367/diff/
Testing (updated)
-------
Before this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1065 ms)
[ OK ] FetcherCacheTest.LocalCached (1728 ms)
[ OK ] FetcherCacheTest.CachedFallback (1105 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```
After this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (984 ms)
[ OK ] FetcherCacheTest.LocalCached (1750 ms)
[ OK ] FetcherCacheTest.CachedFallback (1043 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
[ OK ] FetcherCacheTest.SimpleEviction (2723 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
```
Thanks,
haosdent huang
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
> On Feb. 16, 2016, 11:02 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 422
> > <https://reviews.apache.org/r/43367/diff/4/?file=1239305#file1239305line422>
> >
> > In some fetcher cache tests, we specifically want to find out if concurrent execution of launching taks works. Settling the clock serializes this and thus disables some of desired the testing.
> >
> > How about shortening the allocation interval and not playing with the clock?
Got it, how about change to 500ms?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119293
-----------------------------------------------------------
On Feb. 10, 2016, 4:17 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 4:17 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by reduce
allocation_interval.
Posted by Bernd Mathiske <be...@mesosphere.io>.
> On Feb. 16, 2016, 3:02 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 422
> > <https://reviews.apache.org/r/43367/diff/4/?file=1239305#file1239305line422>
> >
> > In some fetcher cache tests, we specifically want to find out if concurrent execution of launching taks works. Settling the clock serializes this and thus disables some of desired the testing.
> >
> > How about shortening the allocation interval and not playing with the clock?
>
> haosdent huang wrote:
> Got it, how about change to 500ms?
Worth a try :-)
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119293
-----------------------------------------------------------
On Feb. 16, 2016, 3:42 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2016, 3:42 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (984 ms)
> [ OK ] FetcherCacheTest.LocalCached (1750 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1043 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (1006 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1714 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2723 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2220 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2736 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2251 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1514 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1209 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119293
-----------------------------------------------------------
src/tests/fetcher_cache_tests.cpp (line 422)
<https://reviews.apache.org/r/43367/#comment180624>
In some fetcher cache tests, we specifically want to find out if concurrent execution of launching taks works. Settling the clock serializes this and thus disables some of desired the testing.
How about shortening the allocation interval and not playing with the clock?
- Bernd Mathiske
On Feb. 9, 2016, 8:17 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 8:17 p.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up FetcherCache test cases by advance allocation_interval.
>
>
> Diffs
> -----
>
> src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
>
> Diff: https://reviews.apache.org/r/43367/diff/
>
>
> Testing
> -------
>
> Before this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1065 ms)
> [ OK ] FetcherCacheTest.LocalCached (1728 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1105 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
> ```
>
> After this patch:
> ```
> [ OK ] FetcherCacheTest.LocalUncached (1132 ms)
> [ OK ] FetcherCacheTest.LocalCached (1693 ms)
> [ OK ] FetcherCacheTest.CachedFallback (1028 ms)
> [ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
> [ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
> [ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
> [ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
> [ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
> [ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
> [ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
> ```
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 4:17 a.m.)
Review request for mesos and Bernd Mathiske.
Changes
-------
Address @gyliu's comment.
Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618
Repository: mesos
Description
-------
Speed up FetcherCache test cases by advance allocation_interval.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/43367/diff/
Testing
-------
Before this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1065 ms)
[ OK ] FetcherCacheTest.LocalCached (1728 ms)
[ OK ] FetcherCacheTest.CachedFallback (1105 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```
After this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1132 ms)
[ OK ] FetcherCacheTest.LocalCached (1693 ms)
[ OK ] FetcherCacheTest.CachedFallback (1028 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
[ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
```
Thanks,
haosdent huang
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 4:01 a.m.)
Review request for mesos and Bernd Mathiske.
Changes
-------
Address @gyliu's comments.
Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618
Repository: mesos
Description
-------
Speed up FetcherCache test cases by advance allocation_interval.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/43367/diff/
Testing
-------
Before this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1065 ms)
[ OK ] FetcherCacheTest.LocalCached (1728 ms)
[ OK ] FetcherCacheTest.CachedFallback (1105 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```
After this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1132 ms)
[ OK ] FetcherCacheTest.LocalCached (1693 ms)
[ OK ] FetcherCacheTest.CachedFallback (1028 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
[ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
```
Thanks,
haosdent huang
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 1:42 a.m.)
Review request for mesos and Bernd Mathiske.
Changes
-------
Rebase.
Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618
Repository: mesos
Description
-------
Speed up FetcherCache test cases by advance allocation_interval.
Diffs (updated)
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/43367/diff/
Testing
-------
Before this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1065 ms)
[ OK ] FetcherCacheTest.LocalCached (1728 ms)
[ OK ] FetcherCacheTest.CachedFallback (1105 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```
After this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1132 ms)
[ OK ] FetcherCacheTest.LocalCached (1693 ms)
[ OK ] FetcherCacheTest.CachedFallback (1028 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
[ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
```
Thanks,
haosdent huang
Re: Review Request 43367: Speed up FetcherCache test cases by advance
allocation_interval.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 6:30 p.m.)
Review request for mesos and Bernd Mathiske.
Changes
-------
Fill `Testing Done` field.
Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618
Repository: mesos
Description
-------
Speed up FetcherCache test cases by advance allocation_interval.
Diffs
-----
src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf
Diff: https://reviews.apache.org/r/43367/diff/
Testing (updated)
-------
Before this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1065 ms)
[ OK ] FetcherCacheTest.LocalCached (1728 ms)
[ OK ] FetcherCacheTest.CachedFallback (1105 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (906 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[ OK ] FetcherCacheTest.SimpleEviction (3626 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2649 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (3639 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (2608 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1529 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1349 ms)
```
After this patch:
```
[ OK ] FetcherCacheTest.LocalUncached (1132 ms)
[ OK ] FetcherCacheTest.LocalCached (1693 ms)
[ OK ] FetcherCacheTest.CachedFallback (1028 ms)
[ OK ] FetcherCacheTest.LocalUncachedExtract (998 ms)
[ OK ] FetcherCacheTest.LocalCachedExtract (1341 ms)
[ OK ] FetcherCacheTest.SimpleEviction (2056 ms)
[ OK ] FetcherCacheTest.FallbackFromEviction (2146 ms)
[ OK ] FetcherCacheTest.RemoveLRUCacheEntries (2576 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedSerialized (1588 ms)
[ OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1453 ms)
[ OK ] FetcherCacheHttpTest.HttpMixed (1143 ms)
```
Thanks,
haosdent huang