You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jbertram (via GitHub)" <gi...@apache.org> on 2023/04/10 16:17:59 UTC
[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4421: ARTEMIS-4212 fix sending msgs to address w/mismatching routing types
jbertram commented on code in PR #4421:
URL: https://github.com/apache/activemq-artemis/pull/4421#discussion_r1161863645
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/AutoCreateResult.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.api.core;
+
+public enum AutoCreateResult {
+
+ EXISTED, CREATED, UPDATED, NOT_FOUND;
+
+ public byte getType() {
+ switch (this) {
+ case EXISTED:
+ return 0;
+ case CREATED:
+ return 1;
+ case UPDATED:
+ return 2;
+ case NOT_FOUND:
+ return 3;
+ default:
+ return -1;
+ }
+ }
+
+ public static AutoCreateResult getType(byte type) {
+ switch (type) {
+ case 0:
+ return EXISTED;
+ case 1:
+ return CREATED;
+ case 2:
+ return UPDATED;
+ case 3:
+ return NOT_FOUND;
+ default:
+ return null;
Review Comment:
Fixed.
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/AutoCreateResult.java:
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.api.core;
+
+public enum AutoCreateResult {
+
+ EXISTED, CREATED, UPDATED, NOT_FOUND;
+
+ public byte getType() {
+ switch (this) {
+ case EXISTED:
+ return 0;
+ case CREATED:
+ return 1;
+ case UPDATED:
+ return 2;
+ case NOT_FOUND:
+ return 3;
+ default:
+ return -1;
+ }
+ }
+
+ public static AutoCreateResult getType(byte type) {
Review Comment:
Fixed.
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/AddressQueryImpl.java:
##########
@@ -133,4 +141,14 @@ public Integer getDefaultConsumersBeforeDispatch() {
public Long getDefaultDelayBeforeDispatch() {
return defaultDelayBeforeDispatch;
}
+
+ @Override
+ public boolean isSupportsMulticast() {
+ return supportsMulticast;
+ }
+
+ @Override
+ public boolean isSupportsAnycast() {
+ return supportsAnycast;
+ }
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org