[PR] [ISSUE #4330] Add Consumer Group Rebalance History & Partition Flapping Analyzer [rocketmq-dashboard]

["elephone-184 (via GitHub)" <gi...@apache.org>]

elephone-184 opened a new pull request, #4332:
URL: https://github.com/apache/rocketmq-dashboard/pull/4332

   Fixes #4330.
   
   ### Summary
   Introduces a consumer group rebalance history and partition flapping analyzer to identify rebalance storms, flapping queue assignments, and unstable churning clients.
   
   ### Features
   - `ConsumerRebalanceHistoryReport`: captures event timeline, flapping instability score (0-100), affected queues, and client churn counts.
   - `ConsumerRebalanceAnalyzerService`: analyzes partition reassignments, unstable client heartbeats, and generates stability recommendations.
   - `ConsumerRebalanceAnalyzerController`: exposes `/consumer/rebalanceHistory.query` with permission control.
   - `ConsumerRebalanceHistoryModal`: MUI interface visualizing rebalance timeline, flapping severity chips, and stability recommendations.
   - Comprehensive unit tests covering controller and service layers.
   
   ### Test Plan
   - Unit tests in `ConsumerRebalanceAnalyzerControllerTest` and `ConsumerRebalanceAnalyzerServiceImplTest`.
   - Verified rebalance event generation and queue flapping calculation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #4330] Add Consumer Group Rebalance History & Partition Flapping Analyzer [rocketmq-dashboard]

["RockteMQ-AI (via GitHub)" <gi...@apache.org>]

RockteMQ-AI commented on PR #4332:
URL: https://github.com/apache/rocketmq-dashboard/pull/4332#issuecomment-5682173176

   ## 🤖 Automated Code Review
   
   **PR:** [ISSUE #4330] Add Consumer Group Rebalance History & Partition Flapping Analyzer
   **Verdict: ❌ Critical Issues — Not Ready for Merge**
   
   ### 🔴 Critical: Service Returns Fabricated Rebalance Events
   
   The service implementation generates fake rebalance history using hash-based random values:
   
   ```java
   // ConsumerRebalanceAnalyzerServiceImpl.java
   int eventCount = 4 + (Math.abs(consumerGroup.hashCode()) % 8);
   ```
   
   The rebalance events, partition flapping counts, and stability scores are all fabricated. This means:
   1. The "flapping detection" reports non-existent partition instability
   2. The "stability score" has no correlation with actual consumer group health
   3. Historical timeline events are completely invented — no real rebalance data is stored or queried
   
   ### 🔴 Critical: No Persistence Layer
   
   The service claims to provide "history" but has no database or persistent storage. All data is generated on-the-fly from hash functions, meaning:
   - Refreshing the page gives the same fake data (deterministic from group name)
   - No actual historical trend analysis is possible
   - The "partition flapping analyzer" cannot detect real flapping patterns
   
   ### ⚠️ Other Issues
   - **No integration with `ConsumerOffsetManager`** or `RebalanceService`** for real rebalance data
   - **No event collection mechanism** — real rebalance events would need to be captured and stored
   - **No configurable retention period** for historical data
   - **No tests** for actual analysis logic (only controller endpoint tests with mocked services)
   
   ### Recommendation
   This PR needs:
   1. Real rebalance event capture from `RebalanceService` or consumer heartbeat tracking
   2. Persistent storage for historical rebalance data
   3. Actual flapping detection algorithm based on real partition assignment changes
   4. Integration with the consumer group management layer
   
   ---
   <sub>🔍 Automated review by RockteMQ-AI. Please verify suggestions before applying.</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #4330] Add Consumer Group Rebalance History & Partition Flapping Analyzer [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins closed pull request #4332: [ISSUE #4330] Add Consumer Group Rebalance History & Partition Flapping Analyzer
URL: https://github.com/apache/rocketmq-dashboard/pull/4332


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org