You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2026/06/25 17:18:14 UTC
[PR] Remove unused field in JdbcBasePersistenceImpl [polaris]
adutra opened a new pull request, #4892:
URL: https://github.com/apache/polaris/pull/4892
<!--
๐ Describe what changes you're proposing, especially breaking or user-facing changes.
๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
-->
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact security@apache.org)
- [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused field in JdbcBasePersistenceImpl [polaris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4892:
URL: https://github.com/apache/polaris/pull/4892#discussion_r3476312616
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -128,7 +128,6 @@ private JdbcBasePersistenceImpl createSession(
diagnostics,
datasourceOperations,
secretsGenerator(realmId, rootCredentialsSet),
- storageIntegrationProvider,
realmId,
Review Comment:
With the storageIntegrationProvider constructor argument removed, this class now appears to have an unused CDI injection field (and likely an unused import) for PolarisStorageIntegrationProvider. If unused, this can fail style checks and keeps dead wiring around; please remove the unused `@Inject` field and its import.
##########
persistence/relational-jdbc/src/test/java/org/apache/polaris/persistence/relational/jdbc/MetricsReportPersistenceTest.java:
##########
@@ -75,7 +75,6 @@ public PolarisStorageIntegration getStorageIntegration(
diagnostics,
datasourceOperations,
PrincipalSecretsGenerator.RANDOM_SECRETS,
Review Comment:
After removing the storageProvider argument from JdbcBasePersistenceImpl construction, the local storageProvider variable (and its import/type references) in this test looks unused. Please delete the unused PolarisStorageIntegrationProvider import and the unused storageProvider variable block to avoid style-check failures and reduce noise in the test setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused field in JdbcBasePersistenceImpl [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #4892:
URL: https://github.com/apache/polaris/pull/4892#issuecomment-4808601357
> LGTM. `NoSqlMetaStore` also has the same field, and `PolarisDiagnostics diagnostics` is also unused.
FYI https://github.com/apache/polaris/pull/4904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused field in JdbcBasePersistenceImpl [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #4892:
URL: https://github.com/apache/polaris/pull/4892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org