You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "lincoln-lil (via GitHub)" <gi...@apache.org> on 2026/06/22 14:39:23 UTC

[PR] [FLINK-39966][table-planner] FlinkRelMdModifiedMonotonicity wrongly reports a non-time-attribute Top-1 Rank as insert-only [flink]

lincoln-lil opened a new pull request, #28505:
URL: https://github.com/apache/flink/pull/28505

   ## What is the purpose of the change
   
   FLINK-34702 removed the dedicated StreamPhysicalDeduplicate metadata handler and re-routed deduplication monotonicity through StreamPhysicalRank, but the new dispatch guard only checked RankUtil.isDeduplication (Top-1 ROW_NUMBER without rank number). It dropped the sortOnTimeAttributeOnly invariant the old node type implicitly carried.
   
   
   
   ## Brief change log
     - Tighten the guard to isDeduplication && sortOnTimeAttributeOnly restoring the original logic.
     - Add proper test cases
   
   ## Verifying this change
   This change added tests and can be verified as follows:
     - Added plan tests to RankTest.scala
     - Added metadata tests to FlinkRelMdModifiedMonotonicityTest.scala
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-39966][table-planner] FlinkRelMdModifiedMonotonicity wrongly reports a non-time-attribute Top-1 Rank as insert-only [flink]

Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil merged PR #28505:
URL: https://github.com/apache/flink/pull/28505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-39966][table-planner] FlinkRelMdModifiedMonotonicity wrongly reports a non-time-attribute Top-1 Rank as insert-only [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28505:
URL: https://github.com/apache/flink/pull/28505#issuecomment-4769556468

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "61106384f7ccc3188407c8636674fb87a515ab9b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "61106384f7ccc3188407c8636674fb87a515ab9b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 61106384f7ccc3188407c8636674fb87a515ab9b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org