You are viewing a plain text version of this content. The canonical link for it is here.

Posted to cvs@httpd.apache.org by mi...@apache.org on 2018/02/16 16:47:26 UTC

svn commit: r1824533 - /httpd/httpd/branches/2.4.x/STATUS

Author: minfrin
Date: Fri Feb 16 16:47:26 2018
New Revision: 1824533

URL: http://svn.apache.org/viewvc?rev=1824533&view=rev
Log:
Update comment.

Modified:
    httpd/httpd/branches/2.4.x/STATUS

Modified: httpd/httpd/branches/2.4.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1824533&r1=1824532&r2=1824533&view=diff
==============================================================================
--- httpd/httpd/branches/2.4.x/STATUS (original)
+++ httpd/httpd/branches/2.4.x/STATUS Fri Feb 16 16:47:26 2018
@@ -144,7 +144,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
                   http://svn.apache.org/r1824381
      2.4.x patch: svn merge ^/httpd/httpd/branches/2.4.x-mpm_fdqueue .
                   (http://home.apache.org/~ylavic/patches/httpd-2.4.x-mpm_fdqueue.patch)
-     +1: ylavic, minfrin (with mmn bump for mpm_fdqueue.h)
+     +1: ylavic, minfrin
      ylavic: The branch merge helps resolve move conflicts since event and
              worker fdqueue.[ch] differ(ed) between 2.4.x and trunk. The patch
              is provided only to help review.
@@ -154,6 +154,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
      ylavic: not easier/harder than now I suppose (worker/event fqueues are private).
              maybe make them public in trunk only, so that we have more time to
              discuss the API (if needed).
+     minfrin: happy with that, we can backport the final API.
 
   *) mpm_event: Do lingering close in worker(s).
      trunk patch: http://svn.apache.org/r1823047

Re: svn commit: r1824533 - /httpd/httpd/branches/2.4.x/STATUS

Posted by Yann Ylavic <yl...@gmail.com>.

On Fri, Feb 16, 2018 at 5:47 PM,  <mi...@apache.org> wrote:
>
>       ylavic: not easier/harder than now I suppose (worker/event fqueues are private).
>               maybe make them public in trunk only, so that we have more time to
>               discuss the API (if needed).
> +     minfrin: happy with that, we can backport the final API.

Btw, this is an apr_queue already, maybe we could "improve" it with
atomics from httpd's fdqueue (or have a new apr_atomic_queue
possibly).
That's where such (public) data structure belongs in, IMHO.

Regards,
Yann.