You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/10/09 04:43:31 UTC

[GitHub] [commons-lang] arturobernalg commented on a change in pull request #793: Simplify bitwise operations with equivalent and simple.

arturobernalg commented on a change in pull request #793:
URL: https://github.com/apache/commons-lang/pull/793#discussion_r725431839



##########
File path: src/main/java/org/apache/commons/lang3/Conversion.java
##########
@@ -1061,7 +1061,7 @@ public static byte binaryToByte(final boolean[] src, final int srcPos, final byt
         }
         for (int i = 0; i < nInts; i++) {
             final int shift = i * 32 + srcPos;
-            dst[dstPos + i] = (int) (0xffffffff & (src >> shift));
+            dst[dstPos + i] = (int) ((src >> shift));

Review comment:
       HI @garydgregory 
   removed.
   TY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org