You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2023/05/05 09:37:00 UTC
[jira] [Comment Edited] (CASSANDRA-14319) nodetool rebuild from DC lets you pass invalid datacenters
[ https://issues.apache.org/jira/browse/CASSANDRA-14319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719773#comment-17719773 ]
Stefan Miklosovic edited comment on CASSANDRA-14319 at 5/5/23 9:36 AM:
-----------------------------------------------------------------------
I believe the logic should be moved a little bit up so we fail earlier, in StorageService.rebuild method before anything is actually executed where all other checks are.
https://github.com/apache/cassandra/pull/2309
was (Author: smiklosovic):
I believe the logic should be move a little bit up so we fail earlier, in StorageService.rebuild method before anything is actually executed where all other checks are.
https://github.com/apache/cassandra/pull/2309
> nodetool rebuild from DC lets you pass invalid datacenters
> -----------------------------------------------------------
>
> Key: CASSANDRA-14319
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14319
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
> Reporter: Jon Haddad
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
> Attachments: CASSANDRA-14319-trunk.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If you pass an invalid datacenter to nodetool rebuild, you'll get an error like this:
> {code}
> Unable to find sufficient sources for streaming range (3074457345618258602,-9223372036854775808] in keyspace system_distributed
> {code}
> Unfortunately, this is a rabbit hole of frustration if you are using caps for your DC names and you pass in a lowercase DC name, or you just typo the DC.
> Let's do the following:
> # Check the DC name that's passed in against the list of DCs we know about
> # If we don't find it, let's output a reasonable error, and list all the DCs someone could put in.
> # Ideally we indicate which keyspaces are set to replicate to this DC and which aren't
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org