You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "peterdemaeyer (via GitHub)" <gi...@apache.org> on 2025/01/31 21:56:26 UTC
[PR] [MCLEAN-110, MCLEAN-124, MCLEAN-126, ] Merge 3.x to 4.x [maven-clean-plugin]
peterdemaeyer opened a new pull request, #86:
URL: https://github.com/apache/maven-clean-plugin/pull/86
This is a PR for a merge of 3.x `maven-clean-plugin-3.x` to 4.x `master`. In particular, it includes the changes in the context of MCLEAN-110, MCLEAN-124, MCLEAN-126 and nothing else. There were some conflicts and differences between 3.x and 4.x, but I assumed they were intentional so I kept the 4.x behavior and adapted tests accordingly where needed. To preserve the nature of the merge commit, I strongly recommend merging this PR as a regular merge and _not_ a squash merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCLEAN-110, MCLEAN-124, MCLEAN-126, ] Merge 3.x to 4.x [maven-clean-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #86:
URL: https://github.com/apache/maven-clean-plugin/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCLEAN-110, MCLEAN-124, MCLEAN-126, ] Merge 3.x to 4.x [maven-clean-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #86:
URL: https://github.com/apache/maven-clean-plugin/pull/86#issuecomment-2628893934
@peterdemaeyer please look at #84 I will try do the similar 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCLEAN-110, MCLEAN-124, MCLEAN-126, ] Merge 3.x to 4.x [maven-clean-plugin]
Posted by "peterdemaeyer (via GitHub)" <gi...@apache.org>.
peterdemaeyer commented on PR #86:
URL: https://github.com/apache/maven-clean-plugin/pull/86#issuecomment-2629362657
> @peterdemaeyer please look at #84 I will try do the similar 😄
@slawekjaranowski ha, I see now. I prefer your approach for MCLEAN-124 because it aligns the implementations on 3.x and 4.x by preferring the original 3.x solution. I just didn't realize I was allowed to do that, otherwise I would have done the same. :-)
The benefit of this PR is that it is a merge PR for not only MCLEAN-124 but anything else that wasn't merged from 3.x yet, which is just 2 more issues, and I noticed that some parts of the code had already been applied to 4.x via some other way.
I think it's best that #84 gets merged first, and then I need to redo this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCLEAN-110, MCLEAN-124, MCLEAN-126, ] Merge 3.x to 4.x [maven-clean-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #86:
URL: https://github.com/apache/maven-clean-plugin/pull/86#issuecomment-2629544295
@peterdemaeyer #84 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCLEAN-110, MCLEAN-124, MCLEAN-126, ] Merge 3.x to 4.x [maven-clean-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #86:
URL: https://github.com/apache/maven-clean-plugin/pull/86#issuecomment-2667980965
@peterdemaeyer thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCLEAN-110, MCLEAN-124, MCLEAN-126, ] Merge 3.x to 4.x [maven-clean-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #86:
URL: https://github.com/apache/maven-clean-plugin/pull/86#issuecomment-2654547024
@peterdemaeyer do you have a time and wish to rebase this ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCLEAN-110, MCLEAN-124, MCLEAN-126, ] Merge 3.x to 4.x [maven-clean-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #86:
URL: https://github.com/apache/maven-clean-plugin/pull/86#issuecomment-2690267246
Resolve #193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org