[GitHub] [iceberg] szehon-ho commented on a diff in pull request #5346: Substitute the method of PropertyUtil#propertyAsLong for IcebergSource#propertyAsLong

[GitBox <gi...@apache.org>]

szehon-ho commented on code in PR #5346:
URL: https://github.com/apache/iceberg/pull/5346#discussion_r935891855


##########
core/src/main/java/org/apache/iceberg/util/PropertyUtil.java:
##########
@@ -57,7 +57,7 @@ public static int propertyAsInt(Map<String, String> properties,
   }
 
   public static long propertyAsLong(Map<String, String> properties,
-                                    String property, long defaultValue) {
+                                    String property, Long defaultValue) {

Review Comment:
   Not a huge fan of changing signature , even this minor way.
   
   Would a better option be just to change the consuming code to expect a different non-null default value?  (like -1)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org