[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #594: ntpclient.c: Replace home-grown ntp_addr_u with sockaddr_storage

[GitBox <gi...@apache.org>]

yamt commented on a change in pull request #594:
URL: https://github.com/apache/incubator-nuttx-apps/pull/594#discussion_r577214282



##########
File path: netutils/ntpclient/ntpclient.c
##########
@@ -625,14 +699,15 @@ static void ntpc_settime(int64_t offset, FAR struct timespec *start_realtime,
  *
  ****************************************************************************/
 
-static bool ntp_address_in_kod_list(FAR const union ntp_addr_u *server_addr)
+static bool ntp_address_in_kod_list(FAR const struct sockaddr *server_addr)

Review comment:
       i'm not sure if i want to do it.
   
   if you feel strong about casts, i can do
   ```
   union ntp_addr_u
     {
       struct sockaddr sa;
       struct sockaddr_storage ss;
     }
   ```
   does it sound better to you?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org