[GitHub] [flink] fapaul commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors

[GitBox <gi...@apache.org>]

fapaul commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r797966208



##########
File path: flink-end-to-end-tests/test-scripts/test_quickstarts.sh
##########
@@ -41,7 +41,7 @@ mkdir -p "${TEST_DATA_DIR}"
 cd "${TEST_DATA_DIR}"
 
 ARTIFACT_ID=flink-quickstart-${TEST_TYPE}
-ARTIFACT_VERSION=0.1
+ARTIFACT_VERSION=${FLINK_VERSION}

Review comment:
       How did this work before?

##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -55,6 +55,14 @@ under the License.
 			<optional>true</optional>
 		</dependency>
 
+		<dependency>
+			<groupId>org.apache.flink</groupId>
+			<artifactId>flink-connector-base</artifactId>
+			<version>${project.version}</version>
+			<scope>provided</scope>
+			<optional>true</optional>

Review comment:
       I guess the connector-base dependency is optional for all formats since it is probably only required when using a file-based implementation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org