You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "allthingssecurity (via GitHub)" <gi...@apache.org> on 2026/10/01 02:06:05 UTC
[PR] CAMEL-25218: camel-jsonpath - read a remote file with a charset instead of failing with ClassCastException [camel]
allthingssecurity opened a new pull request, #27167:
URL: https://github.com/apache/camel/pull/27167
# Description
[CAMEL-25218](https://issues.apache.org/jira/browse/CAMEL-25218)
`JsonPathEngine.doRead` has a special case for a `GenericFile` with a charset (CAMEL-8905):
```java
if (genericFile.getCharset() != null) {
// special treatment for generic file with charset
InputStream inputStream = new FileInputStream((File) genericFile.getFile());
return JsonPath.using(configuration).parse(inputStream, genericFile.getCharset()).read(path);
}
```
The cast assumes the file consumer. The ftp and ftps consumers also set the endpoint `charset` on the `RemoteFile` they create (`FtpConsumer.asRemoteFile`), but its file is an `FTPFile` and the content is in the body, so every jsonpath expression on such a message fails with `ClassCastException: class org.apache.commons.net.ftp.FTPFile cannot be cast to class java.io.File`, for example `from("ftp://host/inbox?charset=ISO-8859-1").split().jsonpath("$.orders[*]")`. Without the charset option the same route works, but then a file in a charset other than UTF-8/16/32 is decoded wrongly.
This change: a `java.io.File` is still opened with a `FileInputStream`; any other generic file is read through the `GenericFile` type converter (the downloaded content, loaded through the binding if needed). Both are parsed in the file charset as before. Local files behave exactly as before.
Tests:
- `JsonPathRemoteGenericFileCharsetTest` (new): a `GenericFile` whose file is not a `java.io.File` (a stand-in for `FTPFile`, camel-jsonpath does not depend on camel-ftp), with the JSON in the body, charset UTF-8 and ISO-8859-1; control: the same without a charset.
- Without the change, the two tests with a charset fail with `ClassCastException`; the control passes.
- With the change, all camel-jsonpath tests pass: 133 tests, 0 failures.
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
(I built and tested the affected module, including the formatter and import-sort plugins. I did not run the full root build.)
# AI-assisted contributions
- [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used.
This PR was prepared with Claude Code (Claude Opus 5.5). The commit carries a `Co-Authored-By` trailer.
_Claude Code on behalf of allthingssecurity_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25218: camel-jsonpath - read a remote file with a charset instead of failing with ClassCastException [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier merged PR #27167:
URL: https://github.com/apache/camel/pull/27167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25218: camel-jsonpath - read a remote file with a charset instead of failing with ClassCastException [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27167:
URL: https://github.com/apache/camel/pull/27167#issuecomment-5925785083
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-jsonpath`
:repeat: **1 test passed only after a retry on JDK 25** (1 retried attempt)
<details><summary>Recovered flaky tests on JDK 25 (1)</summary>
| Module | Test | Failed attempts | First failure |
| --- | --- | --- | --- |
| `dsl/camel-jbang/camel-jbang-plugin-tui` | `AiPanelAcpTest.usageUpdateFeedsTheTokenCounter` | 1 | array contents differ at index [0], expected: <900> but was: <0> |
> :information_source: These tests did **not** fail the build. Surefire retried them and they passed.
> Retries are enabled project-wide by `surefire.rerunFailingTestsCount` in `parent/pom.xml`.
</details>
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 9 of 697 tested, 27 compile-only — current: 9 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **9 affected modules** (current approach: 9).
**Skip-tests mode would test 9 modules** (1 direct + 8 downstream), **skip tests for 27** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (9)</summary>
- `camel-jbang-mcp` ← downstream of org.apache.camel:camel-catalog
- `camel-jbang-plugin-mcp` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-route-parser` ← downstream of org.apache.camel:camel-route-parser
- `camel-jbang-plugin-tui` ← downstream of org.apache.camel:camel-catalog
- `camel-jbang-plugin-validate` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-jsonpath` ← components/camel-jsonpath/src/main/java/org/apache/camel/jsonpath/JsonPathEngine.java, components/camel-jsonpath/src/test/java/org/apache/camel/jsonpath/JsonPathRemoteGenericFileCharsetTest.java
- `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
- `camel-yaml-dsl-validator` ← downstream of org.apache.camel:camel-catalog
- `camel-yaml-dsl-validator-maven-plugin` ← downstream of org.apache.camel:camel-yaml-dsl-validator
</details>
<details><summary>Modules with tests skipped (27)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (36 modules, 5m 39s total)</summary>
**Total reactor time:** 5m 39s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: Launcher | 51.2s | SUCCESS |
| Camel :: JBang :: MCP | 41.6s | SUCCESS |
| Camel :: JBang :: Plugin :: TUI | 35.8s | SUCCESS |
| Camel :: Component DSL | 27.5s | SUCCESS |
| Camel :: Catalog :: Camel Catalog | 25.2s | SUCCESS |
| Camel :: YAML DSL | 18.2s | SUCCESS |
| Camel :: JSon Path | 17.9s | SUCCESS |
| Camel :: JBang :: Plugin :: Kubernetes | 16.3s | SUCCESS |
| Camel :: Docs | 16.3s | SUCCESS |
| Camel :: Kamelet Main | 10.4s | SUCCESS |
| Camel :: YAML DSL :: Validator | 10.0s | SUCCESS |
| Camel :: YAML DSL :: Deserializers | 8.6s | SUCCESS |
| Camel :: Catalog :: Camel Route Parser | 7.6s | SUCCESS |
| Camel :: JBang :: Plugin :: Testing | 7.5s | SUCCESS |
| Camel :: Catalog :: Camel Report Maven Plugin | 6.7s | SUCCESS |
| Camel :: YAML DSL :: Validator Maven Plugin | 5.8s | SUCCESS |
| Camel :: All Components Sync point | 5.2s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 5.0s | SUCCESS |
| Camel :: Catalog :: Suggest (deprecated) | 3.3s | SUCCESS |
| Camel :: YAML DSL :: Maven Plugins | 3.2s | SUCCESS |
| Camel :: Catalog :: Maven | 2.6s | SUCCESS |
| Camel :: Assembly | 2.0s | SUCCESS |
| Camel :: Catalog :: Dummy Component | 1.8s | SUCCESS |
| Camel :: Coverage | 1.6s | SUCCESS |
| Camel :: JBang :: Plugin :: Edit | 1.4s | SUCCESS |
| Camel :: JBang :: Integration tests | 1.0s | SUCCESS |
| Camel :: JBang :: Plugin :: Generate | 1.0s | SUCCESS |
| Camel :: Catalog :: Console | 1.0s | SUCCESS |
| Camel :: Endpoint DSL :: Support | 0.9s | SUCCESS |
| Camel :: JBang :: Main | 0.7s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 0.7s | SUCCESS |
| Camel :: Launcher :: Container | 0.7s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 0.5s | SUCCESS |
| Camel :: Endpoint DSL | n/a | |
| Camel :: Integration Tests | n/a | |
| Camel :: JBang :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: Launcher` (51.2s)
- `Camel :: JBang :: MCP` (41.6s)
- `Camel :: JBang :: Plugin :: TUI` (35.8s)
- `Camel :: Component DSL` (27.5s)
- `Camel :: Catalog :: Camel Catalog` (25.2s)
- `Camel :: YAML DSL` (18.2s)
- `Camel :: JSon Path` (17.9s)
- `Camel :: JBang :: Plugin :: Kubernetes` (16.3s)
- `Camel :: Docs` (16.3s)
- `Camel :: Kamelet Main` (10.4s)
- `Camel :: YAML DSL :: Validator` (10.0s)
- `Camel :: YAML DSL :: Deserializers` (8.6s)
- `Camel :: Catalog :: Camel Route Parser` (7.6s)
- `Camel :: JBang :: Plugin :: Testing` (7.5s)
- `Camel :: Catalog :: Camel Report Maven Plugin` (6.7s)
- `Camel :: YAML DSL :: Validator Maven Plugin` (5.8s)
- `Camel :: All Components Sync point` (5.2s)
- `Camel :: JBang :: Plugin :: Validate` (5.0s)
- `Camel :: Catalog :: Suggest (deprecated)` (3.3s)
- `Camel :: YAML DSL :: Maven Plugins` (3.2s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/36804227729)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25218: camel-jsonpath - read a remote file with a charset instead of failing with ClassCastException [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27167:
URL: https://github.com/apache/camel/pull/27167#issuecomment-5925486343
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org