You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/04/03 15:53:21 UTC
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1101: DISPATCH-2030
jiridanek opened a new pull request #1101:
URL: https://github.com/apache/qpid-dispatch/pull/1101
1. UBSAN is not killing the process the moment undefined behavior is detected. This is easily fixed by doing `set(RUNTIME_UBSAN_ENV_OPTIONS "halt_on_error=1 abort_on_error=1")`, but then the tests timeout all the time. Not useful.
2. UBSAN is not printing diagnostics. That is fixed by doing `set(RUNTIME_UBSAN_ENV_OPTIONS "print_stacktrace=1 print_summary=1")`
3. ASAN has extra checks that can be enabled. Enabling them does not find any new issues, so far. But it sounds like a sensible thing to turn on, for the future. `set(RUNTIME_ASAN_ENV_OPTIONS "strict_string_checks=1 detect_stack_use_after_return=1 check_initialization_order=1 strict_init_order=1")`
4. System tests don't print `.out` files produced by running routers, even if there are messages from sanitizers in them. Let's fix that. This means that tests become _quite_ chatty. Maybe not something that should be turned on forever, but now it's good to see the UBSAN messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1101: DISPATCH-2030 Add additional sanitizer checks and surface router output better in tests
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #1101:
URL: https://github.com/apache/qpid-dispatch/pull/1101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on pull request #1101: DISPATCH-2030
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1101:
URL: https://github.com/apache/qpid-dispatch/pull/1101#issuecomment-812888707
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1101?src=pr&el=h1) Report
> Merging [#1101](https://codecov.io/gh/apache/qpid-dispatch/pull/1101?src=pr&el=desc) (acbeade) into [main](https://codecov.io/gh/apache/qpid-dispatch/commit/961829142dee8dc6734b92174b11193732911edd?el=desc) (9618291) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
- Coverage 82.26% 82.24% -0.03%
==========================================
Files 111 111
Lines 27537 27537
==========================================
- Hits 22654 22648 -6
- Misses 4883 4889 +6
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1101?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1101/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `85.71% <0.00%> (-0.69%)` | :arrow_down: |
| [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1101/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.12% <0.00%> (-0.39%)` | :arrow_down: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1101/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `88.53% <0.00%> (-0.10%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1101/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.69% <0.00%> (+0.10%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1101?src=pr&el=footer). Last update [9618291...acbeade](https://codecov.io/gh/apache/qpid-dispatch/pull/1101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1101: DISPATCH-2030 Add additional sanitizer checks and surface router output better in tests
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1101:
URL: https://github.com/apache/qpid-dispatch/pull/1101#issuecomment-815953160
This change does not appear to cause any extra test failures as I was afraid (esp. regarding the strict_string_checking asan flag), so after offline review, I will push this based on silent consensus principle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org