You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Ethan Li (JIRA)" <ji...@apache.org> on 2019/08/10 22:14:00 UTC
[jira] [Updated] (STORM-3472) STORM-3411 should have tests, and we
shouldn't catch NPE for control flow
[ https://issues.apache.org/jira/browse/STORM-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ethan Li updated STORM-3472:
----------------------------
Affects Version/s: (was: 2.0.1)
2.0.0
Fix Version/s: (was: 2.0.1)
2.1.0
> STORM-3411 should have tests, and we shouldn't catch NPE for control flow
> -------------------------------------------------------------------------
>
> Key: STORM-3472
> URL: https://issues.apache.org/jira/browse/STORM-3472
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-webapp
> Affects Versions: 2.0.0
> Reporter: Stig Rohde Døssing
> Assignee: Stig Rohde Døssing
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.1.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I think the code merged in STORM-3411 should have added tests that the new functionality works.
> We should get rid of the new bit of code that try-catches an NPE to check whether the downloaded file is inside a worker dir. Instead, we should move the name generation up the call hierarchy to a place where we can tell whether we're inside a worker dir or not.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)