You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/06/13 15:17:11 UTC
[GitHub] gbates101 commented on issue #4595: sqllab: preview should quote
table name
gbates101 commented on issue #4595: sqllab: preview should quote table name
URL: https://github.com/apache/incubator-superset/issues/4595#issuecomment-396975566
+1 on this. From what I can tell, a custom template processor will be needed for whatever database engine you're using. I believe it will require adding a new template processor class in the ` jinja_context` module by extending this class:
https://github.com/apache/incubator-superset/blob/502b617310e2f133ecd8626e0ed3d9ef4f0bf9cd/superset/jinja_context.py#L64
Looks like the template processor is invoked in the 'sql_json' endpoint, here:
https://github.com/apache/incubator-superset/blob/7f30b48955e249f972b1764697893aa54a43fb4c/superset/views/core.py#L2416-L2424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org