[GitHub] [nifi] nandorsoma commented on a change in pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL

[GitBox <gi...@apache.org>]

nandorsoma commented on a change in pull request #5475:
URL: https://github.com/apache/nifi/pull/5475#discussion_r735730301



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -482,6 +490,15 @@
             .allowableValues("True", "False")
             .build();
 
+    public static final PropertyDescriptor UPDATE_FILENAME = new PropertyDescriptor.Builder()
+            .name("update-filename")
+            .description("If true and HTTP method is GET, the FlowFile's filename will be extracted from the remote URL.")
+            .displayName("Update Filename")

Review comment:
       Hey! Thank you for your review!
   Maybe I'm just not familiar of the concept what required means here. I thought in this situation it practically means we are not allowing null as a value. Since here null doesn't add anything to us I decided to set it true. Did I do it wrong?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org