You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/09 17:23:17 UTC

[GitHub] [airflow] josh-fell commented on a diff in pull request #24347: Add salesforce_default to List Connection

josh-fell commented on code in PR #24347:
URL: https://github.com/apache/airflow/pull/24347#discussion_r893773031


##########
airflow/utils/db.py:
##########
@@ -533,6 +533,13 @@ def create_default_connections(session: Session = NEW_SESSION):
         ),
         session,
     )
+    merge_conn(
+        Connection(
+            conn_id="salesforce_default",
+            conn_type="salesforce",

Review Comment:
   I think it would be really nice to have some connection attributes filled in (even with bogus values like the others here) for what _could_ be a "useful" example connection.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org