[GitHub] [pulsar] lhotari commented on a diff in pull request #15751: PIP-105 add support for updating the Subscription properties

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #15751:
URL: https://github.com/apache/pulsar/pull/15751#discussion_r888682978


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1527,6 +1527,43 @@ public void resetCursor(
         }
     }
 
+    @POST
+    @Path("/{tenant}/{namespace}/{topic}/subscription/{subName}/updateProperties")

Review Comment:
   ```suggestion
       @PUT
       @Path("/{tenant}/{namespace}/{topic}/subscription/{subName}/properties")
   ```
   
   It would be more RESTful to model the properties as a resource that can be updated with `PUT`. 
   It would also be RESTful to make a GET return the existing properties.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org