You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "crimsondhaks (via GitHub)" <gi...@apache.org> on 2026/05/28 12:46:43 UTC

[PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

crimsondhaks opened a new pull request, #40500:
URL: https://github.com/apache/superset/pull/40500

   > Linking back to my comment on #40460 — going ahead with the PR. Happy to close if there's already work in flight on someone else's branch.
   
   ### SUMMARY
   
   Long localized "Modified at" strings (e.g. the German `Geändert vor ungefähr einer Stunde und siebenundzwanzig Minuten`) were wrapping onto multiple lines or getting clipped inside dashboard, chart, saved-query, and tag list cards.
   
   Root cause: `ListViewCard` passes the `description` prop straight through to AntD's `Card.Meta` with no overflow handling, while the sibling `title` and `titleRight` elements in the same component already use an `ellipsis + Tooltip` pattern.
   
   This PR mirrors that existing pattern for `description`:
   
   - Adds `overflow: hidden; text-overflow: ellipsis; white-space: nowrap;` for `.ant-card-meta-description` inside the existing `StyledCard` wrapper.
   - Wraps the rendered description in the same `Tooltip` component already used elsewhere in the file so the full localized text is reachable on hover.
   
   No prop signature changes; consumers (`DashboardCard`, `ChartCard`, `SavedQueries`, `TagCard`) remain untouched.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Tested in the Storybook `Interactive List View Card` story at the `Small mobile (P)` viewport (320 px) with `description="Geändert vor ungefähr einer Stunde und siebenundzwanzig Minuten"`.
   
   **Before** — description wraps onto two lines and would be clipped in real layouts where card height is fixed.
   
   **After** — description truncates to a single line with ellipsis.
   
   **After (hover)** — tooltip surfaces the full localized text.
   
   <!-- Drag and drop your three screenshots here: before, after, after-with-tooltip -->
   
   ### TESTING INSTRUCTIONS
   
   1. Run Storybook from `superset-frontend/`:
      ```
      npm run storybook
      ```
   2. Open `Components / ListViewCard / Interactive List View Card`.
   3. Switch the viewport to `Small mobile (P)` (320 px) using Storybook's viewport toolbar.
   4. In the Controls panel, set `description` to a long localized string, e.g. `Geändert vor ungefähr einer Stunde und siebenundzwanzig Minuten`.
   5. Confirm the description renders on a single line ending in `...`.
   6. Hover the truncated text and confirm the tooltip shows the full original string.
   7. Existing `ListViewCard.test.tsx` continues to pass — no behavioral assertions were broken because the change is CSS + a passthrough wrapper.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #40460
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #40500:
URL: https://github.com/apache/superset/pull/40500#discussion_r3347082835


##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -49,6 +49,23 @@ const StyledCard = styled(Card)`
         transform: translateY(0);
       }
     }
+
+    /* Truncate long descriptions (e.g. localized "Modified at" timestamps)
+       so they don't overflow the card. The full value remains accessible
+       via the tooltip wrapper applied around the description. */
+    .ant-card-meta-description {
+      overflow: hidden;
+      text-overflow: ellipsis;
+      white-space: nowrap;
+      
+      /* Ensure ellipsis works by making the span behave as block-level */
+      span {
+        display: block;
+        overflow: hidden;
+        text-overflow: ellipsis;
+        white-space: nowrap;
+      }
+    }

Review Comment:
   The selector `.ant-card-meta-description span` is broad and will affect any span rendered inside the description (including future non-text descriptions). This makes the styling fragile to markup changes. Consider adding a dedicated class to the wrapped description element (e.g., the span you render in `description={...}`) and targeting that class instead, so truncation is scoped only to this specific text node.



##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -259,7 +276,13 @@ function ListViewCard({
               </div>
             </TitleContainer>
           }
-          description={description}
+          description={
+            description ? (
+              <Tooltip title={description}>
+                <span>{description}</span>
+              </Tooltip>
+            ) : null
+          }

Review Comment:
   The tooltip trigger is a plain `span`, which is not keyboard-focusable by default, so keyboard users may not be able to access the full description. Consider making the trigger focusable (e.g., `tabIndex={0}`) and ensure the tooltip also opens on focus (via explicit trigger configuration if needed) so the full text is accessible without a mouse.



##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -49,6 +49,23 @@ const StyledCard = styled(Card)`
         transform: translateY(0);
       }
     }
+
+    /* Truncate long descriptions (e.g. localized "Modified at" timestamps)
+       so they don't overflow the card. The full value remains accessible
+       via the tooltip wrapper applied around the description. */
+    .ant-card-meta-description {
+      overflow: hidden;
+      text-overflow: ellipsis;
+      white-space: nowrap;
+      

Review Comment:
   There is trailing whitespace on this blank line, which can cause noisy diffs and lint issues in some setups. Remove the extra spaces to keep formatting clean.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate overflowed "Modified at" timestamps field [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4678347273

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate overflowed "Modified at" timestamps field [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4701124850

   Please verify your fix with setup in the linked issue (real Superset setup with frontend and server + German language setting). Storybook component doesn't show the whole picture.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4568580001

   🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/26603036030) for [fb20802](https://github.com/apache/superset/commit/fb20802)
   
   • **Environment:** http://184.32.244.27:8080 (admin/admin)
   • **Lifetime:** 48h auto-cleanup
   • **Updates:** New commits create fresh environments automatically


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate overflowed "Modified at" timestamps field [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4677275748

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | d29331730b0162bbf30e5a6ed8ec11a2b6945659 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a2a3db203da0a00095fd687 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-40500--superset-docs-preview.netlify.app](https://deploy-preview-40500--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQwNTAwLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.pIFv3X9OKc4bSbbtdZNo0Fk0DRsjBTC3YHrU9xZMoHY)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctRCoMwDADQu-R7xaDMbd7AY8SmZYHOlFisMry7_Xs_7w_Z9JcLTAAPWIxW_22OcnRJtuJ2CdV5MnYcNm-Si-jqdA8Wk9ZWOOSk58wtjdTTwEuPAxMSIn6ekcf3C64b) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-40500--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4568448079

   🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/26603036030) for [fb20802](https://github.com/apache/superset/commit/fb20802)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate overflowed "Modified at" timestamps field [superset]

Posted by "crimsondhaks (via GitHub)" <gi...@apache.org>.
crimsondhaks commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4677275449

   @hainenber Fixed - descriptions now wrap without being covered. Screenshot attached showing it working in Storybook.
   <img width="1788" height="1088" alt="image" src="https://github.com/user-attachments/assets/ad2aa2f7-42a8-4ae3-950b-acc6fc97f9f3" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate overflowed "Modified at" timestamps field [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4661216268

   @crimsondhaks can you please verify with your development setup? I couldn't confirm the fix on my side with your latest commit
   
   <img width="1040" height="359" alt="image" src="https://github.com/user-attachments/assets/f2830af3-7e97-49b3-97f6-c12756700cf0" />
   
   It appears your fix expanded the top padding a bit but didn't work out for the covered description and the status pill.
   
   <img width="671" height="209" alt="image" src="https://github.com/user-attachments/assets/4282ef3f-116f-4ed7-86fc-7e06f9d75563" />
   
   Please follow the [Developer Guide](https://superset.apache.org/developer-docs/contributing/development-setup) to help setting the project's dev env so that you can verify the fix. I'll review again once you've done the due diligence.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #40500:
URL: https://github.com/apache/superset/pull/40500#discussion_r3347387422


##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -49,6 +49,13 @@ const StyledCard = styled(Card)`
         transform: translateY(0);
       }
     }
+
+    /* Allow long descriptions (e.g. localized "Modified at" timestamps)
+       to wrap naturally instead of being clipped by the card. */
+    .ant-card-meta-description {
+      white-space: normal;
+      overflow-wrap: anywhere;
+    }

Review Comment:
   `overflow-wrap: anywhere` has less consistent behavior/support across some older browsers. If this component must support them, consider adding a more broadly-supported fallback (e.g., `overflow-wrap: break-word` and/or `word-break: break-word`) so wrapping still works when `anywhere` isn’t honored.



##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -259,7 +266,7 @@ function ListViewCard({
               </div>
             </TitleContainer>
           }
-          description={description}
+          description={description || null}

Review Comment:
   `description || null` will coerce valid falsy values (e.g., `0`, `false`, and `''`) to `null`. If `description` is typed as `ReactNode`, those are valid nodes and should be preserved. Prefer nullish coalescing so only `null`/`undefined` become `null` (e.g., `description={description ?? null}`)."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #40500:
URL: https://github.com/apache/superset/pull/40500#discussion_r3346918674


##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -259,7 +268,15 @@ function ListViewCard({
               </div>
             </TitleContainer>
           }
-          description={description}
+          description={
+            description ? (
+              <Tooltip title={description}>
+                <span>{description}</span>
+              </Tooltip>
+            ) : (
+              description
+            )
+          }

Review Comment:
   The conditional `description ? (...) : description` is harder to reason about because it relies on truthiness and returns the same expression in the `else` branch. Consider using an explicit nullish check (or a string-length check if the intent is only to tooltip non-empty strings) to avoid surprising behavior for empty strings and to simplify the control flow.



##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -259,7 +268,15 @@ function ListViewCard({
               </div>
             </TitleContainer>
           }
-          description={description}
+          description={
+            description ? (
+              <Tooltip title={description}>
+                <span>{description}</span>
+              </Tooltip>
+            ) : (
+              description
+            )
+          }

Review Comment:
   The tooltip content is only reliably accessible via hover because the child is a non-focusable `span`. To make the full description accessible to keyboard users, make the trigger element focusable (e.g., add `tabIndex={0}`) and ensure the tooltip also opens on focus (depending on Tooltip defaults in your Ant version).



##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -49,6 +49,15 @@ const StyledCard = styled(Card)`
         transform: translateY(0);
       }
     }
+
+    /* Truncate long descriptions (e.g. localized "Modified at" timestamps)
+       so they don't overflow the card. The full value remains accessible
+       via the tooltip wrapper applied around the description. */
+    .ant-card-meta-description {
+      overflow: hidden;
+      text-overflow: ellipsis;
+      white-space: nowrap;
+    }

Review Comment:
   This forces *all* descriptions in this card to a single line (`white-space: nowrap`), which is a behavior change for any descriptions that were previously intended to wrap over multiple lines. If only certain fields (like timestamps) need truncation, consider scoping the truncation to a dedicated wrapper/class for those fields, or use a multi-line clamp approach so descriptions can still wrap (while preventing overflow).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #40500:
URL: https://github.com/apache/superset/pull/40500#discussion_r3346982651


##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -259,7 +268,13 @@ function ListViewCard({
               </div>
             </TitleContainer>
           }
-          description={description}
+          description={
+            description ? (
+              <Tooltip title={description}>
+                <span tabIndex={0}>{description}</span>

Review Comment:
   Making the description text focusable with `tabIndex={0}` introduces an extra tab stop per card, which can significantly degrade keyboard navigation in dense card lists. Consider using an ellipsis+tooltip pattern that doesn’t require adding a new focus target (e.g., `Typography.Text` with ellipsis+tooltip), or only adding keyboard focus when truncation actually occurs.



##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -49,6 +49,15 @@ const StyledCard = styled(Card)`
         transform: translateY(0);
       }
     }
+
+    /* Truncate long descriptions (e.g. localized "Modified at" timestamps)
+       so they don't overflow the card. The full value remains accessible
+       via the tooltip wrapper applied around the description. */
+    .ant-card-meta-description {
+      overflow: hidden;
+      text-overflow: ellipsis;
+      white-space: nowrap;
+    }

Review Comment:
   `text-overflow: ellipsis` only consistently applies when the element is a block/inline-block with a constrained width, and it won’t affect inline children. Since the description content is now wrapped in a `<span>`, truncation may not work reliably unless the truncation styles apply to the actual text-containing element (or the container is made `display: block`/`inline-block` with an explicit width constraint like `max-width: 100%`, and sometimes `min-width: 0` in flex layouts). Suggest adjusting the CSS to ensure the rendered text element is the one receiving the ellipsis behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #40500:
URL: https://github.com/apache/superset/pull/40500#discussion_r3347450601


##########
superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx:
##########
@@ -49,6 +49,14 @@ const StyledCard = styled(Card)`
         transform: translateY(0);
       }
     }
+
+    /* Allow long descriptions (e.g. localized "Modified at" timestamps)
+       to wrap naturally instead of being clipped by the card. */
+    .ant-card-meta-description {
+      white-space: normal;
+      overflow-wrap: break-word;
+      word-break: break-word;
+    }

Review Comment:
   `word-break: break-word` is non-standard CSS and may not behave consistently across browsers. Prefer relying on `overflow-wrap` alone, or replace this with a standards-based option like `overflow-wrap: anywhere` (and keep `word-break: normal`) to get consistent wrapping for long unbroken strings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4568433107

   "Modified at" strings are pretty important, to a lot of users. You mention they get wrapped or cut off, but which is it? If they wrap, I'm OK with that. If they're cut off, I'd like to see them wrap. Truncating may be cleaner looking, but I'm a bit worried about losing critical info that verifies the freshness/truth of the data displayed. If the card needs to be redesigned a bit (cc @kasiazjc) I'm even open to that. 
   
   It'd be good to see the before/after images in the product, if it's possible to do so. I'll spin up an ephemeral test env here so you can do so if you're willing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate overflowed "Modified at" timestamps field [superset]

Posted by "crimsondhaks (via GitHub)" <gi...@apache.org>.
crimsondhaks commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4659213004

   @hainenber Fixed! Added padding to prevent the description from being covered by the status pill. Should work now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate overflowed "Modified at" timestamps field [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4660700404

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4565150438

   Thanks for this fix @crimsondhaks ! Please see this expectations checklist for new contributors: https://github.com/apache/superset/wiki/New-Contributor-Welcome-&-Expectations In particular, could you include before/after screenshots and add some human-written text to your PR description? Currently it seems like it was written completely by AI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4564103533

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4565238959

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40500?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `50.00000%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 64.17%. Comparing base ([`c73106b`](https://app.codecov.io/gh/apache/superset/commit/c73106b7a285f54dc9fc80826881c42bbf26c17d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fb20802`](https://app.codecov.io/gh/apache/superset/commit/fb2080246f87ab423a0a15c7b72ad2cd9be986e2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/40500?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rset-ui-core/src/components/ListViewCard/index.tsx](https://app.codecov.io/gh/apache/superset/pull/40500?src=pr&el=tree&filepath=superset-frontend%2Fpackages%2Fsuperset-ui-core%2Fsrc%2Fcomponents%2FListViewCard%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29tcG9uZW50cy9MaXN0Vmlld0NhcmQvaW5kZXgudHN4) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40500?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #40500      +/-   ##
   ==========================================
   - Coverage   64.17%   64.17%   -0.01%     
   ==========================================
     Files        2592     2592              
     Lines      139299   139301       +2     
     Branches    32347    32349       +2     
   ==========================================
   + Hits        89395    89396       +1     
   - Misses      48367    48368       +1     
     Partials     1537     1537              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/40500/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/40500/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.33% <50.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40500?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "crimsondhaks (via GitHub)" <gi...@apache.org>.
crimsondhaks commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4570744167

   yeah "cut off" was my bad , it's actually clipped by the card, not wrapped.
   
   so it's truncate + tooltip (what i did, but no hover on touch) vs just letting it wrap (always shows full text, costs a little height).
   
   since you're ok with wrapping and don't want the timestamp hidden, happy to switch to wrapping — white-space: normal + making sure the card gives it room instead of clipping. want me to go that way, or wait for @kasiazjc?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(list-view-card): truncate long descriptions and surface full text… [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40500:
URL: https://github.com/apache/superset/pull/40500#issuecomment-4611701035

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org