You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Gus Heck (JIRA)" <ji...@apache.org> on 2019/03/25 02:36:00 UTC

[jira] [Resolved] (SOLR-13323) Remove org.apache.solr.internal.csv.writer.CSVWriter (and related classes)

     [ https://issues.apache.org/jira/browse/SOLR-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gus Heck resolved SOLR-13323.
-----------------------------
       Resolution: Fixed
    Fix Version/s: master (9.0)
                   8.1

> Remove org.apache.solr.internal.csv.writer.CSVWriter (and related classes)
> --------------------------------------------------------------------------
>
>                 Key: SOLR-13323
>                 URL: https://issues.apache.org/jira/browse/SOLR-13323
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (9.0)
>            Reporter: Gus Heck
>            Priority: Minor
>             Fix For: 8.1, master (9.0)
>
>
> This class appears to only be used in the test for itself. It's also easily confused with org.apache.solr.response.CSVWriter 
> I propose we remove this class entirely. Is there any reason to believe from it's past history (of which I know nothing) that it might be depended upon by outside code and require a deprecation cycle? 
> Presently it contains a System.out.println and a eclipse generated catch block that precommit won't like if we enable checking for System.out.println, which is why this ticket is a sub-task. If we do need to deprecate it then I propose we remove the print and simply re-throw the exception as a RuntimeException



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org