You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/06 11:50:58 UTC

[GitHub] [arrow] Crystrix opened a new pull request #10459: [C++][Compute] Passing options parameter of Count aggregation by reference

Crystrix opened a new pull request #10459:
URL: https://github.com/apache/arrow/pull/10459


   The options parameter of `Count` function is passed by value, it's better to be passed by reference like other aggregation functions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10459: [C++][Compute] Passing options parameter of Count aggregation by reference

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10459:
URL: https://github.com/apache/arrow/pull/10459#issuecomment-855386506


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cyb70289 closed pull request #10459: ARROW-12984: [C++][Compute] Passing options parameter of Count/Index aggregation by reference

Posted by GitBox <gi...@apache.org>.
cyb70289 closed pull request #10459:
URL: https://github.com/apache/arrow/pull/10459


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10459: ARROW-12984: [C++][Compute] Passing options parameter of Count aggregation by reference

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10459:
URL: https://github.com/apache/arrow/pull/10459#issuecomment-855386970


   https://issues.apache.org/jira/browse/ARROW-12984


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cyb70289 commented on pull request #10459: ARROW-12984: [C++][Compute] Passing options parameter of Count aggregation by reference

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10459:
URL: https://github.com/apache/arrow/pull/10459#issuecomment-855565488


   Thanks @Crystrix !
   Will you also update `Index` function?
   https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/api_aggregate.cc#L80


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Crystrix commented on pull request #10459: ARROW-12984: [C++][Compute] Passing options parameter of Count aggregation by reference

Posted by GitBox <gi...@apache.org>.
Crystrix commented on pull request #10459:
URL: https://github.com/apache/arrow/pull/10459#issuecomment-855601219


   @cyb70289  Sure, `Index` function has also been updated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org