You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/09/01 18:07:21 UTC
[GitHub] couchdb-fauxton pull request: Minor extension check
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/512
Minor extension check
Small thing. If the 'mango:additionalIndexes' extension isn't
defined it throws a JS error and causes the page not to load.
This just adds a check.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton minor-extension-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #512
----
commit 51933b2745a48ec72ba0d7bbcaa015685ea05313
Author: Ben Keen <be...@gmail.com>
Date: 2015-08-31T21:52:23Z
Increase timeout for NW tests
The max timeout time for several of the NW custom commands was
set to 10 seconds. Recently NW tests have been failing a good deal
more (esp on the dash) and all appear to be due to timeouts.
This PR changes it to use the default timeout time (30 seconds). I
think this is wise in any event, since ANY effort to increase the
robustness of the tests is needed. Plus it won't slow anything
down - just any test that's legitimately failing.
commit 3ea432f547a397bb2e9a0ec25ef5fed7e6a33df0
Author: Ben Keen <be...@gmail.com>
Date: 2015-09-01T16:02:54Z
Check extension is defined before referencing
Small thing. If the 'mango:additionalIndexes' extension isn't
defined it throws a JS error and causes the page not to load.
This just adds a check.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extension check
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/512#issuecomment-136780696
looks good but a unit test is missing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extension check
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/512#issuecomment-138988963
K. Closin'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extension check
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/512#issuecomment-138985914
fauxton has no optional extensions defined, and does not crash and that's cool.
right now it errors if you try to use extensions, that are registered in a wrong way. these extensions are partly registered and not set up properly.
crashing here is better compared to failing silently which will introduce cascading errors or weird behavior where the extension should be used. it also makes debugging very hard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extension check
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/512#issuecomment-137035496
i think we can close this now. imo it is good that it crashes if the extension is missing and not failing silently
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extension check
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/512
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extension check
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/512#issuecomment-136780748
Oh rats.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extension check
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/512#issuecomment-138587638
I don't know... seems like extensions are by design *optional*, so crashing when one isn't defined seems kind of inelegant. Plus that way looking at the codebase I'd never know which extensions needed to be defined or not in order for a chunk of code to run. I think we should supply an alternate test to confirm that it's working as expected (actually, I think one may already exist).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---