You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "wilx (via GitHub)" <gi...@apache.org> on 2026/08/08 13:55:43 UTC
[PR] Migrate legacy plugin Javadoc annotations [maven-site-plugin]
wilx opened a new pull request, #1289:
URL: https://github.com/apache/maven-site-plugin/pull/1289
This updates the plugin sources in the MSITE-504, `it-plugin-test`, and
`new-configuration` integration-test projects to use
`maven-plugin-annotations` instead of the legacy Maven Plugin Tools Javadoc
tags.
The conversion preserves each mojo's name, default lifecycle phase, and
parameter metadata. All three fixtures now declare
`maven-plugin-annotations` with `provided` scope and use the existing filtered
`@version.maven-plugin-tools@` value so they stay aligned with the Plugin Tools
version used by the reactor.
This is part of removing reliance on the legacy QDox-backed Javadoc-tag
extractor discussed in https://github.com/apache/maven-plugin-tools/issues/718.
There is no runtime behavior change to the Site Plugin.
Validation on Maven 3.9.16 and JDK 21:
- `mvn -B -V clean verify -Prun-its`
- Invoker: 61 passed, 0 failed, 0 errors, 0 skipped
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in other changes.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice. This change updates existing integration-test fixtures and does not change runtime behavior.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate legacy plugin Javadoc annotations [maven-site-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #1289:
URL: https://github.com/apache/maven-site-plugin/pull/1289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate legacy plugin Javadoc annotations [maven-site-plugin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1289:
URL: https://github.com/apache/maven-site-plugin/pull/1289#issuecomment-5231903471
@slachiewicz The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: master" to the description to the milestone where this PR belongs to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org