[jira] Commented: (JCR-1304) Support system properties in ${...} vars in XML config files

["Alexander Klimetschek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557654#action_12557654 ] 

Alexander Klimetschek commented on JCR-1304:
--------------------------------------------

I just found nothing using Text.replaceVariables apart from the config files ;-)

Is RepositoryConfig.create ok? AFAIU it parses repository.xml. What about a workspace.xml of an exisiting workspace? Will it still contain the variables or are they replaced by their values when the workspace.xml is created?

> Support system properties in ${...} vars in XML config files
> ------------------------------------------------------------
>
>                 Key: JCR-1304
>                 URL: https://issues.apache.org/jira/browse/JCR-1304
>             Project: Jackrabbit
>          Issue Type: New Feature
>          Components: config, jackrabbit-jcr-commons
>    Affects Versions: 1.3.3, 1.4, 1.5
>            Reporter: Alexander Klimetschek
>         Attachments: enable-system-props-in-config-vars.patch, JCR-1304.patch
>
>
> The variable replacement (${...}) in config files like repository.xml currently only allows for the special variables introduced by Jackrabbit, eg. ${wsp.name} or ${rep.home}. But it would be useful to support all java system properties here as it is some kind of a standard in Java XML config files (see Spring for an example).
> This makes it easier to inject variables from outside the config file, eg. by setting them on the command line or injecting them programmatically in test cases. Typical parameters for that include database connection credentials, which one wants to avoid to put into repository.xml files that are often checked into SVN.
> This is especially true for test cases, eg. I currently work on a persistence manager component and I want to include the repository.xml in the source tree (under applications/test) but without my specific credentials. These are applied by loading a user-specific properties file through the test case before the repository is started and the config is read.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.