You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2023/03/02 06:47:18 UTC

[GitHub] [iceberg] ajantha-bhat opened a new pull request, #6983: Build: Fix minor errorprone warnings during compile

ajantha-bhat opened a new pull request, #6983:
URL: https://github.com/apache/iceberg/pull/6983

   Before
   <img width="790" alt="Screenshot 2023-03-02 at 12 06 39 PM" src="https://user-images.githubusercontent.com/5889404/222351916-2e252d94-52b9-49bf-9486-6d1264ad7344.png">
   
   After
   <img width="790" alt="image" src="https://user-images.githubusercontent.com/5889404/222352003-00626610-0d70-4c2e-9d7c-b10ee8ba3553.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] huaxingao commented on pull request #6983: Build: Fix minor errorprone warnings during compile

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #6983:
URL: https://github.com/apache/iceberg/pull/6983#issuecomment-1451385438

   @ajantha-bhat Thanks for catching the problem!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] Fokko merged pull request #6983: Build: Fix minor errorprone warnings during compile

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #6983:
URL: https://github.com/apache/iceberg/pull/6983


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] Fokko commented on a diff in pull request #6983: Build: Fix minor errorprone warnings during compile

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #6983:
URL: https://github.com/apache/iceberg/pull/6983#discussion_r1122681296


##########
baseline.gradle:
##########
@@ -86,6 +86,8 @@ subprojects {
           '-Xep:PreferSafeLogger:OFF',
           // Enforce safe string splitting
           '-Xep:StringSplitter:ERROR',
+          // Enforce missing override
+          '-Xep:MissingOverride:ERROR',

Review Comment:
   Nice!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] ajantha-bhat commented on pull request #6983: Build: Fix minor errorprone warnings during compile

Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #6983:
URL: https://github.com/apache/iceberg/pull/6983#issuecomment-1451379254

   cc: @Fokko  , @huaxingao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org