You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2023/01/07 17:30:22 UTC
[GitHub] [cxf] reta opened a new pull request, #1056: CXF-8758: Migration path for Wiremock (Jetty 11/JakartaEE)
reta opened a new pull request, #1056:
URL: https://github.com/apache/cxf/pull/1056
Migration path for Wiremock (Jetty 11/JakartaEE)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta merged pull request #1056: CXF-8758: Migration path for Wiremock (Jetty 11/JakartaEE)
Posted by GitBox <gi...@apache.org>.
reta merged PR #1056:
URL: https://github.com/apache/cxf/pull/1056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #1056: CXF-8758: Migration path for Wiremock (Jetty 11/JakartaEE)
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #1056:
URL: https://github.com/apache/cxf/pull/1056#discussion_r1064250247
##########
systests/microprofile/client/weld/pom.xml:
##########
@@ -201,6 +171,13 @@
</configuration>
</execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>com.github.tomakehurst</groupId>
+ <artifactId>wiremock-standalone</artifactId>
+ <version>2.27.2</version>
Review Comment:
@jimma totally makes sense, thank you. The end goal is to use `wiremock` 3.0.0 but sadly `microprofile-rest-client-tck` still depends on `javax.servlet` [1], I was thinking of submitting the pull request there first (since we already have `wiremock` beta release).
[1] https://github.com/eclipse/microprofile-rest-client/blob/master/tck/src/main/java/org/eclipse/microprofile/rest/client/tck/sse/MyEventSourceServlet.java#L22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma commented on a diff in pull request #1056: CXF-8758: Migration path for Wiremock (Jetty 11/JakartaEE)
Posted by GitBox <gi...@apache.org>.
jimma commented on code in PR #1056:
URL: https://github.com/apache/cxf/pull/1056#discussion_r1064241163
##########
systests/microprofile/client/weld/pom.xml:
##########
@@ -201,6 +171,13 @@
</configuration>
</execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>com.github.tomakehurst</groupId>
+ <artifactId>wiremock-standalone</artifactId>
+ <version>2.27.2</version>
Review Comment:
@reta Very minor thing. Can this be upgraded to 2.35.0 ? From https://github.com/automatictester/wiremock-maven-plugin/releases, it looks 7.3.0 can work with 2.35.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma commented on a diff in pull request #1056: CXF-8758: Migration path for Wiremock (Jetty 11/JakartaEE)
Posted by GitBox <gi...@apache.org>.
jimma commented on code in PR #1056:
URL: https://github.com/apache/cxf/pull/1056#discussion_r1064241163
##########
systests/microprofile/client/weld/pom.xml:
##########
@@ -201,6 +171,13 @@
</configuration>
</execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>com.github.tomakehurst</groupId>
+ <artifactId>wiremock-standalone</artifactId>
+ <version>2.27.2</version>
Review Comment:
@reta Can this be upgraded to 2.35.0 ? From https://github.com/automatictester/wiremock-maven-plugin/releases, it looks 7.3.0 can work with 2.35.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on a diff in pull request #1056: CXF-8758: Migration path for Wiremock (Jetty 11/JakartaEE)
Posted by GitBox <gi...@apache.org>.
reta commented on code in PR #1056:
URL: https://github.com/apache/cxf/pull/1056#discussion_r1064250247
##########
systests/microprofile/client/weld/pom.xml:
##########
@@ -201,6 +171,13 @@
</configuration>
</execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>com.github.tomakehurst</groupId>
+ <artifactId>wiremock-standalone</artifactId>
+ <version>2.27.2</version>
Review Comment:
@jimma totally makes sens but sadly `microprofile-rest-client-tck` still depends on `javax.servlet` [1], I was thinking of submitting the pull request there first (since we already have `wiremock` beta release).
[1] https://github.com/eclipse/microprofile-rest-client/blob/master/tck/src/main/java/org/eclipse/microprofile/rest/client/tck/sse/MyEventSourceServlet.java#L22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] jimma commented on a diff in pull request #1056: CXF-8758: Migration path for Wiremock (Jetty 11/JakartaEE)
Posted by GitBox <gi...@apache.org>.
jimma commented on code in PR #1056:
URL: https://github.com/apache/cxf/pull/1056#discussion_r1064241163
##########
systests/microprofile/client/weld/pom.xml:
##########
@@ -201,6 +171,13 @@
</configuration>
</execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>com.github.tomakehurst</groupId>
+ <artifactId>wiremock-standalone</artifactId>
+ <version>2.27.2</version>
Review Comment:
@reta Very minor thing : can this be upgraded to 2.35.0 ? From https://github.com/automatictester/wiremock-maven-plugin/releases, it looks 7.3.0 can work with 2.35.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org