You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Remko Popma (JIRA)" <ji...@apache.org> on 2019/06/21 05:05:00 UTC
[jira] [Commented] (LOG4J2-2635) Wrong java.version check in
ThreadNameCachingStrategy
[ https://issues.apache.org/jira/browse/LOG4J2-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869190#comment-16869190 ]
Remko Popma commented on LOG4J2-2635:
-------------------------------------
I think you’re right, this is a bug.
Will you be able to provide a pull request or patch with a fix?
> Wrong java.version check in ThreadNameCachingStrategy
> -----------------------------------------------------
>
> Key: LOG4J2-2635
> URL: https://issues.apache.org/jira/browse/LOG4J2-2635
> Project: Log4j 2
> Issue Type: Bug
> Reporter: Filipp Gunbin
> Priority: Major
>
> I see this in ThreadNameCachingStrategy.java:
> {code:java}
> final String defaultStrategy = System.getProperty("java.version").compareTo("1.8.0_102") < 0
> ? "CACHED" // LOG4J2-2052 JDK 8u102 removed the String allocation in Thread.getName()
> : "UNCACHED";{code}
> This doesn't look right because java.version of, say, "1.8.0_77" compares greater than "1.8.0_102" lexicographically. This is why I have failed tests when trying to build log4j-core.
> Similar check is also present in AsyncLoggerThreadNameStrategyTest.java.
> This was initially added in https://issues.apache.org/jira/browse/LOG4J2-2052
> [posted this on dev mailing list first, but got no response, so creating issue here]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)