You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/03 08:19:52 UTC

[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request #4149: Fixes #4043, raw-yaml can configure none sharding strategy.

KomachiSion opened a new pull request #4149: Fixes #4043, raw-yaml can configure none sharding strategy.
URL: https://github.com/apache/incubator-shardingsphere/pull/4149
 
 
   Fixes #4043.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.
URL: https://github.com/apache/incubator-shardingsphere/pull/4149#issuecomment-581309205
 
 
   ## Pull Request Test Coverage Report for [Build 1584](https://coveralls.io/builds/28492144)
   
   * **24** of **37**   **(64.86%)**  changed or added relevant lines in **11** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.03%**) to **65.2%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/28492144/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L123) | 1 | 2 | 50.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/yaml/YamlShardingDataSourceFactory.java](https://coveralls.io/builds/28492144/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2Fyaml%2FYamlShardingDataSourceFactory.java#L51) | 0 | 4 | 0.0%
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/yaml/engine/YamlEngine.java](https://coveralls.io/builds/28492144/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fyaml%2Fengine%2FYamlEngine.java#L58) | 0 | 8 | 0.0%
   <!-- | **Total:** | **24** | **37** | **64.86%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28492144/badge)](https://coveralls.io/builds/28492144) |
   | :-- | --: |
   | Change from base [Build 762](https://coveralls.io/builds/28491120): |  0.03% |
   | Covered Lines: | 10919 |
   | Relevant Lines: | 16747 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.
URL: https://github.com/apache/incubator-shardingsphere/pull/4149#issuecomment-581309205
 
 
   ## Pull Request Test Coverage Report for [Build 1582](https://coveralls.io/builds/28491657)
   
   * **24** of **38**   **(63.16%)**  changed or added relevant lines in **11** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.03%**) to **65.2%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/yaml/constructor/construct/YamlNoneShardingStrategyConfigurationConstruct.java](https://coveralls.io/builds/28491657/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fyaml%2Fconstructor%2Fconstruct%2FYamlNoneShardingStrategyConfigurationConstruct.java#L41) | 1 | 2 | 50.0%
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/28491657/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L123) | 1 | 2 | 50.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/yaml/YamlShardingDataSourceFactory.java](https://coveralls.io/builds/28491657/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2Fyaml%2FYamlShardingDataSourceFactory.java#L51) | 0 | 4 | 0.0%
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/yaml/engine/YamlEngine.java](https://coveralls.io/builds/28491657/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fyaml%2Fengine%2FYamlEngine.java#L58) | 0 | 8 | 0.0%
   <!-- | **Total:** | **24** | **38** | **63.16%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28491657/badge)](https://coveralls.io/builds/28491657) |
   | :-- | --: |
   | Change from base [Build 762](https://coveralls.io/builds/28491120): |  0.03% |
   | Covered Lines: | 10919 |
   | Relevant Lines: | 16747 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.
URL: https://github.com/apache/incubator-shardingsphere/pull/4149#issuecomment-581309205
 
 
   ## Pull Request Test Coverage Report for [Build 1586](https://coveralls.io/builds/28492261)
   
   * **25** of **39**   **(64.1%)**  changed or added relevant lines in **11** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.03%**) to **65.202%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/yaml/constructor/construct/YamlNoneShardingStrategyConfigurationConstruct.java](https://coveralls.io/builds/28492261/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fyaml%2Fconstructor%2Fconstruct%2FYamlNoneShardingStrategyConfigurationConstruct.java#L38) | 2 | 3 | 66.67%
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/28492261/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L123) | 1 | 2 | 50.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/yaml/YamlShardingDataSourceFactory.java](https://coveralls.io/builds/28492261/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2Fyaml%2FYamlShardingDataSourceFactory.java#L51) | 0 | 4 | 0.0%
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/yaml/engine/YamlEngine.java](https://coveralls.io/builds/28492261/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fyaml%2Fengine%2FYamlEngine.java#L58) | 0 | 8 | 0.0%
   <!-- | **Total:** | **25** | **39** | **64.1%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28492261/badge)](https://coveralls.io/builds/28492261) |
   | :-- | --: |
   | Change from base [Build 762](https://coveralls.io/builds/28491120): |  0.03% |
   | Covered Lines: | 10920 |
   | Relevant Lines: | 16748 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.
URL: https://github.com/apache/incubator-shardingsphere/pull/4149#issuecomment-581309205
 
 
   ## Pull Request Test Coverage Report for [Build 1581](https://coveralls.io/builds/28491585)
   
   * **24** of **38**   **(63.16%)**  changed or added relevant lines in **11** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.03%**) to **65.2%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/yaml/constructor/construct/YamlNoneShardingStrategyConfigurationConstruct.java](https://coveralls.io/builds/28491585/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fyaml%2Fconstructor%2Fconstruct%2FYamlNoneShardingStrategyConfigurationConstruct.java#L41) | 1 | 2 | 50.0%
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/28491585/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L123) | 1 | 2 | 50.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/yaml/YamlShardingDataSourceFactory.java](https://coveralls.io/builds/28491585/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2Fyaml%2FYamlShardingDataSourceFactory.java#L51) | 0 | 4 | 0.0%
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/yaml/engine/YamlEngine.java](https://coveralls.io/builds/28491585/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fyaml%2Fengine%2FYamlEngine.java#L58) | 0 | 8 | 0.0%
   <!-- | **Total:** | **24** | **38** | **63.16%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28491585/badge)](https://coveralls.io/builds/28491585) |
   | :-- | --: |
   | Change from base [Build 762](https://coveralls.io/builds/28491120): |  0.03% |
   | Covered Lines: | 10919 |
   | Relevant Lines: | 16747 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4149: Fixes #4043, raw-yaml can configure none sharding strategy.

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4149: Fixes #4043, raw-yaml can configure none sharding strategy.
URL: https://github.com/apache/incubator-shardingsphere/pull/4149
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4149: Fixes #4043, raw-yaml can configure none sharding strategy.
URL: https://github.com/apache/incubator-shardingsphere/pull/4149#issuecomment-581309205
 
 
   ## Pull Request Test Coverage Report for [Build 1585](https://coveralls.io/builds/28492466)
   
   * **25** of **39**   **(64.1%)**  changed or added relevant lines in **11** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.03%**) to **65.202%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/yaml/constructor/construct/YamlNoneShardingStrategyConfigurationConstruct.java](https://coveralls.io/builds/28492466/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fyaml%2Fconstructor%2Fconstruct%2FYamlNoneShardingStrategyConfigurationConstruct.java#L38) | 2 | 3 | 66.67%
   | [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/yaml/YamlOrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/28492466/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2Fyaml%2FYamlOrchestrationShardingDataSourceFactory.java#L123) | 1 | 2 | 50.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/api/yaml/YamlShardingDataSourceFactory.java](https://coveralls.io/builds/28492466/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fapi%2Fyaml%2FYamlShardingDataSourceFactory.java#L51) | 0 | 4 | 0.0%
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/yaml/engine/YamlEngine.java](https://coveralls.io/builds/28492466/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fyaml%2Fengine%2FYamlEngine.java#L58) | 0 | 8 | 0.0%
   <!-- | **Total:** | **25** | **39** | **64.1%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28492466/badge)](https://coveralls.io/builds/28492466) |
   | :-- | --: |
   | Change from base [Build 762](https://coveralls.io/builds/28491120): |  0.03% |
   | Covered Lines: | 10920 |
   | Relevant Lines: | 16748 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services