You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by ku...@apache.org on 2020/04/22 20:56:16 UTC
[incubator-gobblin] branch master updated: [GOBBLIN-1124] Add
exception error message.
This is an automated email from the ASF dual-hosted git repository.
kuyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git
The following commit(s) were added to refs/heads/master by this push:
new 63b0e30 [GOBBLIN-1124] Add exception error message.
63b0e30 is described below
commit 63b0e304c772d83136b349954ef1e7387a39e398
Author: Kuai Yu <ku...@linkedin.com>
AuthorDate: Wed Apr 22 13:56:06 2020 -0700
[GOBBLIN-1124] Add exception error message.
Closes #2964 from yukuai518/error
---
.../java/org/apache/gobblin/converter/AsyncHttpJoinConverter.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gobblin-modules/gobblin-http/src/main/java/org/apache/gobblin/converter/AsyncHttpJoinConverter.java b/gobblin-modules/gobblin-http/src/main/java/org/apache/gobblin/converter/AsyncHttpJoinConverter.java
index 8be755b..3e75f32 100644
--- a/gobblin-modules/gobblin-http/src/main/java/org/apache/gobblin/converter/AsyncHttpJoinConverter.java
+++ b/gobblin-modules/gobblin-http/src/main/java/org/apache/gobblin/converter/AsyncHttpJoinConverter.java
@@ -30,6 +30,7 @@ import com.typesafe.config.ConfigFactory;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.exception.ExceptionUtils;
import org.apache.gobblin.async.AsyncRequest;
import org.apache.gobblin.async.AsyncRequestBuilder;
import org.apache.gobblin.async.BufferedRecord;
@@ -140,7 +141,8 @@ public abstract class AsyncHttpJoinConverter<SI, SO, DI, DO, RQ, RP> extends Asy
justification = "CompletableFuture will replace null value with NIL")
@Override
public void onFailure(Throwable throwable) {
- log.error ("Http converter on failure with request {}", request.getRawRequest());
+ String errorMsg = ExceptionUtils.getMessage(throwable);
+ log.error ("Http converter on failure with request {} and throwable {}", request.getRawRequest(), errorMsg);
if (skipFailedRecord) {
AsyncHttpJoinConverterContext.this.future.complete( null);