You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Deepak Barr <de...@gmail.com> on 2016/03/08 20:17:33 UTC
Review Request 44524: HIVE-11484 : Fix ObjectInspector for Char and
VarChar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44524/
-----------------------------------------------------------
Review request for hive and Amareshwari Sriramadasu.
Bugs: HIVE-11484
https://issues.apache.org/jira/browse/HIVE-11484
Repository: hive-git
Description
-------
Fixed ObjectInspectorConverter and Java ObjectInspector for Char and Varchar
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java 3514726
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java f429709
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java a8e34ff
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 5eb41d5
Diff: https://reviews.apache.org/r/44524/diff/
Testing
-------
Yes.
Thanks,
Deepak Barr
Re: Review Request 44524: HIVE-11484 : Fix ObjectInspector for Char
and VarChar
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44524/#review123098
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java (line 41)
<https://reviews.apache.org/r/44524/#comment185243>
Can you add unit test?
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java (line 53)
<https://reviews.apache.org/r/44524/#comment185244>
Can you add unit test?
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java (line 531)
<https://reviews.apache.org/r/44524/#comment185245>
Can you add unit test?
- Amareshwari Sriramadasu
On March 8, 2016, 7:17 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44524/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 7:17 p.m.)
>
>
> Review request for hive and Amareshwari Sriramadasu.
>
>
> Bugs: HIVE-11484
> https://issues.apache.org/jira/browse/HIVE-11484
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Fixed ObjectInspectorConverter and Java ObjectInspector for Char and Varchar
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java 3514726
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java f429709
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java a8e34ff
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 5eb41d5
>
> Diff: https://reviews.apache.org/r/44524/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 44524: HIVE-11484 : Fix ObjectInspector for Char
and VarChar
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44524/#review128339
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 30, 2016, 1:43 p.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44524/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 1:43 p.m.)
>
>
> Review request for hive and Amareshwari Sriramadasu.
>
>
> Bugs: HIVE-11484
> https://issues.apache.org/jira/browse/HIVE-11484
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Fixed ObjectInspectorConverter and Java ObjectInspector for Char and Varchar
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java 3514726
> common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java 969d474
> common/src/test/org/apache/hadoop/hive/common/type/TestHiveBaseChar.java 2848465
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java f429709
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java a8e34ff
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 5eb41d5
> serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java dd18517
> serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 7d87666
>
> Diff: https://reviews.apache.org/r/44524/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Deepak Barr
>
>
Re: Review Request 44524: HIVE-11484 : Fix ObjectInspector for Char
and VarChar
Posted by Deepak Barr <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44524/
-----------------------------------------------------------
(Updated March 30, 2016, 1:43 p.m.)
Review request for hive and Amareshwari Sriramadasu.
Changes
-------
Added testcases
Bugs: HIVE-11484
https://issues.apache.org/jira/browse/HIVE-11484
Repository: hive-git
Description
-------
Fixed ObjectInspectorConverter and Java ObjectInspector for Char and Varchar
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java 3514726
common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java 969d474
common/src/test/org/apache/hadoop/hive/common/type/TestHiveBaseChar.java 2848465
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java f429709
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java a8e34ff
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 5eb41d5
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java dd18517
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java 7d87666
Diff: https://reviews.apache.org/r/44524/diff/
Testing
-------
Yes.
Thanks,
Deepak Barr
Re: Review Request 44524: HIVE-11484 : Fix ObjectInspector for Char
and VarChar
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44524/#review122697
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On March 9, 2016, 12:47 a.m., Deepak Barr wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44524/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 12:47 a.m.)
>
>
> Review request for hive and Amareshwari Sriramadasu.
>
>
> Bugs: HIVE-11484
> https://issues.apache.org/jira/browse/HIVE-11484
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Fixed ObjectInspectorConverter and Java ObjectInspector for Char and Varchar
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java 3514726
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java f429709
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java a8e34ff
> serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java 5eb41d5
>
> Diff: https://reviews.apache.org/r/44524/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Deepak Barr
>
>