You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "sureshanaparti (via GitHub)" <gi...@apache.org> on 2024/06/24 04:43:37 UTC
[PR] [UI] Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page [cloudstack]
sureshanaparti opened a new pull request, #9288:
URL: https://github.com/apache/cloudstack/pull/9288
### Description
This PR fixes action buttons view when public IP address is selected, in Network -> Public IP addresses page
Fixes #8106
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
**Before Fix =>**
<img width="1266" alt="UI_PublicIPAddrBeforeFix" src="https://github.com/apache/cloudstack/assets/12028987/699f68ad-be3f-4999-aeaf-e2acd88025ae">
**After Fix =>**
<img width="1268" alt="UI_PublicIPAddrAfterFix" src="https://github.com/apache/cloudstack/assets/12028987/2edbcd29-6fa5-4ce2-8a89-c9854eac1e1d">
### How Has This Been Tested?
Accessed Network -> Public IP addresses page in UI, and selected public IP address & checked the action buttons.
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #9288:
URL: https://github.com/apache/cloudstack/pull/9288#issuecomment-3154019414
> @sureshanaparti This was never merged, how we overcome this issue then?, any other PR were raised?
@Imvedansh this solution has inconsistent action buttons view display in different window sizes, so not the right one to merge. I don't see any other PR raised for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #9288:
URL: https://github.com/apache/cloudstack/pull/9288#issuecomment-2185595000
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9288:
URL: https://github.com/apache/cloudstack/pull/9288#issuecomment-2185608673
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9288 (QA-JID-385)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #9288:
URL: https://github.com/apache/cloudstack/pull/9288#issuecomment-2185606861
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9288?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.28%. Comparing base [(`083ac06`)](https://app.codecov.io/gh/apache/cloudstack/commit/083ac069ca47a8f96ed9306994e5fbe66352ebc0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`451ce19`)](https://app.codecov.io/gh/apache/cloudstack/commit/451ce19fd780f139bb2561b7e94abe4482879de2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 9 commits behind head on 4.19.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.19 #9288 +/- ##
========================================
- Coverage 4.28% 4.28% -0.01%
========================================
Files 363 363
Lines 29393 29395 +2
Branches 5139 5139
========================================
Hits 1260 1260
- Misses 27990 27992 +2
Partials 143 143
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9288/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.28% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9288?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page [cloudstack]
Posted by "Imvedansh (via GitHub)" <gi...@apache.org>.
Imvedansh commented on PR #9288:
URL: https://github.com/apache/cloudstack/pull/9288#issuecomment-3149596606
@sureshanaparti This was never merged, how we overcome this issue then?, any other PR were raised?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [UI] Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9288:
URL: https://github.com/apache/cloudstack/pull/9288#issuecomment-2185595396
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org