You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/01/24 23:19:54 UTC

[GitHub] [mesos] bbannier commented on pull request #377: [MESOS-10203] fix agent crash on unknown capabilities

bbannier commented on pull request #377:
URL: https://github.com/apache/mesos/pull/377#issuecomment-766458127


   Fixed by 4ce33ca..900d233.
   
   ```
   commit 900d23337c76824328340ca3d3151fb2f1c45ba7
   Author: Charles-Francois Natali <cf...@gmail.com>
   Date:   Sun Jan 24 17:15:34 2021 +0000
   
       Added CAP_PERFMON, CAP_BPF and CAP_CHECKPOINT_RESTORE support.
       
       Part of fix for #10203.
   
   commit 8b5bdb2fb0338c47ed61dbdbe0e4cc4d07386f74
   Author: Charles-Francois Natali <cf...@gmail.com>
   Date:   Sat Jan 23 18:51:57 2021 +0000
   
       Fixed agent crash when kernel supports unknown capabilities.
       
       When capabilities are enabled, the capabilities initialisation code
       would check that /proc/sys/kernel/cap_last_cap is less than
       MAX_CAPABILITY, i.e. that the kernel doesn't support any capability the
       code doesn't expect.  However the error message attempted to format
       cap_last_cap value as a Capability enum, which would crash.
       
       Part of fix for #10203.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org