You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/09/19 14:58:10 UTC
[GitHub] [couchdb-helm] colearendt opened a new pull request, #95: add service.labels and fix ingress service reference
colearendt opened a new pull request, #95:
URL: https://github.com/apache/couchdb-helm/pull/95
#### What this PR does / why we need it:
The ingress was mistakenly pointed to the headless service required for maintaining the statefulset. This means that `service.annotations`, etc. were not useful for controlling ingress behavior.
It might be desirable to change service names at some point to indicate which is headless / internal. However, that could be a disruptive action to any existing environments.
#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*
- fixes #94
#### Special notes for your reviewer:
#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
- [ ] Chart Version bumped
- [ ] e2e tests pass
- [ ] Variables are documented in the README.md
- [ ] Chart tgz added to /docs and index updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #95: add service.labels and fix ingress service reference
Posted by GitBox <gi...@apache.org>.
willholley commented on PR #95:
URL: https://github.com/apache/couchdb-helm/pull/95#issuecomment-1338880910
@colearendt can you describe how you envisage `NEWS.md` being managed? I need to update the repository README and GitHub templates to support the release process via GitHub actions and it's not entirely clear to me what steps are manual now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] lbruun commented on pull request #95: add service.labels and fix ingress service reference
Posted by GitBox <gi...@apache.org>.
lbruun commented on PR #95:
URL: https://github.com/apache/couchdb-helm/pull/95#issuecomment-1354275818
> It might be desirable to change service names at some point to indicate which is headless / internal. However, that could be a disruptive action to any existing environments.
Well, it might be desirable just to **document** why there are two and what their respective purpose is. Been looking in many places for this.
As for this PR, @colearendt , I suspect it will have an easier life if it would leave out the `NEWS.md` file. It seems to sidetrack the important discussion that this PR (and its associated Issue) raises.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley merged pull request #95: add service.labels and fix ingress service reference
Posted by GitBox <gi...@apache.org>.
willholley merged PR #95:
URL: https://github.com/apache/couchdb-helm/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] colearendt commented on pull request #95: add service.labels and fix ingress service reference
Posted by GitBox <gi...@apache.org>.
colearendt commented on PR #95:
URL: https://github.com/apache/couchdb-helm/pull/95#issuecomment-1354658643
@willholley Totally missed your approval here, sorry about that!
That's a fantastic question. I will fix the merge conflict. I suspect there are ways to automate the NEWS.md, but the way that I usually do it is just on each PR:
- bump the Chart version
- add an associated header to `NEWS.md`
- CI checks that chart version is bumped, and `NEWS.md` is a convenience.
This creates potential for merge conflicts, but in practice has worked pretty well 🤷♂️ . I'm definitely happy to help draft contributing docs if that'd be useful!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] colearendt commented on pull request #95: add service.labels and fix ingress service reference
Posted by GitBox <gi...@apache.org>.
colearendt commented on PR #95:
URL: https://github.com/apache/couchdb-helm/pull/95#issuecomment-1354762483
@willholley this is ready to merge 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org