[GitHub] [lucene] Yuti-G commented on pull request #11768: Fix tie-break bug in various Facets implementations

[GitBox <gi...@apache.org>]

Yuti-G commented on PR #11768:
URL: https://github.com/apache/lucene/pull/11768#issuecomment-1255341964

   Thanks @gsmiller for discovering this issue! The changes look good to me.
   
   I am curious if the `index` in `LongIntCursor` works similarly to `ordinals` in other faceting implementation? If so, do you think we should also return `a.count < b.count || (a.count == b.count && a.value > b.value) || (a.count == b.count && a.value == b.value && a.index < b.index)` in the `lessThan()` function of the PQ in `getTopChildrenSortByCount` in the `LongValueFacetCounts` class? Please let me know if I misunderstand the `index` here. Thank you so much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org