[jira] [Commented] (DRILL-3927) Use OutOfMemoryException in more places

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955590#comment-14955590 ] 

ASF GitHub Bot commented on DRILL-3927:
---------------------------------------

GitHub user cwestin opened a pull request:

    https://github.com/apache/drill/pull/199

    DRILL-3927: use OutOfMemoryException in more places

    Some code cleanup required for the upcoming introduction of the rewritten
    direct memory allocator. Chiefly the introduction of OutOfMemoryException
    handling in a few spots, the use of DrillAutoCloseables for some allocator
    close() calls, and some other minor cleanup.
    - removed the exclusion of exec/work from the jdbc-all jar, because it now
      depends on OutOfMemoryException, and that is derived from
      FragmentSetupException and Foreman Exception
    
    Unit tests pass
    Regression suite passes, except for
    - a couple of the known "Exceeded timeout (10000) while waiting send intermediate work fragments to remote nodes."
    - a couple of the known "Selected column 'dir0' must have name 'columns' or must be plain '*'"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cwestin/incubator-drill hygiene-gamma

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #199
    
----
commit e7e95a261523846617e62880fdb9a20448ac818c
Author: Chris Westin <cw...@yahoo.com>
Date:   2015-10-09T21:08:09Z

    DRILL-3927: use OutOfMemoryException in more places
    Some code cleanup required for the upcoming introduction of the rewritten
    direct memory allocator. Chiefly the introduction of OutOfMemoryException
    handling in a few spots, the use of DrillAutoCloseables for some allocator
    close() calls, and some other minor cleanup.
    - removed the exclusion of exec/work from the jdbc-all jar, because it now
      depends on OutOfMemoryException, and that is derived from
      FragmentSetupException and Foreman Exception

----


> Use OutOfMemoryException in more places
> ---------------------------------------
>
>                 Key: DRILL-3927
>                 URL: https://issues.apache.org/jira/browse/DRILL-3927
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>
> The new allocator uses OutOfMemoryException in better ways; some additional exception handling sites need to catch and handle this exception in preparation for the new allocator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)